Re: [PATCH bpf] libbpf: Prevent overriding errno when logging errors

2020-08-13 Thread Toke Høiland-Jørgensen
Daniel Borkmann writes: > On 8/13/20 9:52 PM, Toke Høiland-Jørgensen wrote: >> Andrii Nakryiko writes: >>> On Thu, Aug 13, 2020 at 7:29 AM Toke Høiland-Jørgensen >>> wrote: Turns out there were a few more instances where libbpf didn't save the errno before writing an error messa

Re: [PATCH bpf] libbpf: Prevent overriding errno when logging errors

2020-08-13 Thread Daniel Borkmann
On 8/13/20 9:52 PM, Toke Høiland-Jørgensen wrote: Andrii Nakryiko writes: On Thu, Aug 13, 2020 at 7:29 AM Toke Høiland-Jørgensen wrote: Turns out there were a few more instances where libbpf didn't save the errno before writing an error message, causing errno to be overridden by the printf()

Re: [PATCH bpf] libbpf: Prevent overriding errno when logging errors

2020-08-13 Thread Toke Høiland-Jørgensen
Andrii Nakryiko writes: > On Thu, Aug 13, 2020 at 7:29 AM Toke Høiland-Jørgensen > wrote: >> >> Turns out there were a few more instances where libbpf didn't save the >> errno before writing an error message, causing errno to be overridden by >> the printf() return and the error disappearing if

Re: [PATCH bpf] libbpf: Prevent overriding errno when logging errors

2020-08-13 Thread Andrii Nakryiko
On Thu, Aug 13, 2020 at 7:29 AM Toke Høiland-Jørgensen wrote: > > Turns out there were a few more instances where libbpf didn't save the > errno before writing an error message, causing errno to be overridden by > the printf() return and the error disappearing if logging is enabled. > > Signed-off

[PATCH bpf] libbpf: Prevent overriding errno when logging errors

2020-08-13 Thread Toke Høiland-Jørgensen
Turns out there were a few more instances where libbpf didn't save the errno before writing an error message, causing errno to be overridden by the printf() return and the error disappearing if logging is enabled. Signed-off-by: Toke Høiland-Jørgensen --- tools/lib/bpf/libbpf.c | 12 +++-