Re: [PATCH bpf] bpf: fix sanitation rewrite in case of non-pointers

2019-03-06 Thread Jakub Sitnicki
On Tue, Mar 05, 2019 at 03:30 PM CET, Daniel Borkmann wrote: > On 03/05/2019 03:12 PM, Jakub Sitnicki wrote: > [...] >> Could you please queue it for -stable which has d3bd7413e0ca ("bpf: fix >> sanitation of alu op with pointer / scalar type from different paths")? > > Already done here yesterday

Re: [PATCH bpf] bpf: fix sanitation rewrite in case of non-pointers

2019-03-05 Thread Daniel Borkmann
On 03/05/2019 03:12 PM, Jakub Sitnicki wrote: [...] > Could you please queue it for -stable which has d3bd7413e0ca ("bpf: fix > sanitation of alu op with pointer / scalar type from different paths")? Already done here yesterday morning: https://lore.kernel.org/stable/40b25ec1c31e234cf7eee75d62083

Re: [PATCH bpf] bpf: fix sanitation rewrite in case of non-pointers

2019-03-05 Thread Jakub Sitnicki
On Fri, Mar 01, 2019 at 10:05 PM CET, Daniel Borkmann wrote: > Marek reported that he saw an issue with the below snippet in that > timing measurements where off when loaded as unpriv while results > were reasonable when loaded as privileged: > > [...] > uint64_t a = bpf_ktime_get_ns(); >

Re: [PATCH bpf] bpf: fix sanitation rewrite in case of non-pointers

2019-03-02 Thread Sergei Shtylyov
Hello! On 02.03.2019 0:05, Daniel Borkmann wrote: Marek reported that he saw an issue with the below snippet in that timing measurements where off when loaded as unpriv while results Were? were reasonable when loaded as privileged: [...] uint64_t a = bpf_ktime_get_ns(); u

Re: [PATCH bpf] bpf: fix sanitation rewrite in case of non-pointers

2019-03-01 Thread Alexei Starovoitov
On Fri, Mar 01, 2019 at 10:05:29PM +0100, Daniel Borkmann wrote: > Marek reported that he saw an issue with the below snippet in that > timing measurements where off when loaded as unpriv while results > were reasonable when loaded as privileged: > > [...] > uint64_t a = bpf_ktime_get_ns()

Re: [PATCH bpf] bpf: fix sanitation rewrite in case of non-pointers

2019-03-01 Thread Song Liu
On Fri, Mar 1, 2019 at 3:23 PM Daniel Borkmann wrote: > > On 03/02/2019 12:18 AM, Song Liu wrote: > > On Fri, Mar 1, 2019 at 1:06 PM Daniel Borkmann wrote: > >> > >> Marek reported that he saw an issue with the below snippet in that > >> timing measurements where off when loaded as unpriv while r

Re: [PATCH bpf] bpf: fix sanitation rewrite in case of non-pointers

2019-03-01 Thread Daniel Borkmann
On 03/02/2019 12:18 AM, Song Liu wrote: > On Fri, Mar 1, 2019 at 1:06 PM Daniel Borkmann wrote: >> >> Marek reported that he saw an issue with the below snippet in that >> timing measurements where off when loaded as unpriv while results >> were reasonable when loaded as privileged: >> >> [...

Re: [PATCH bpf] bpf: fix sanitation rewrite in case of non-pointers

2019-03-01 Thread Song Liu
On Fri, Mar 1, 2019 at 1:06 PM Daniel Borkmann wrote: > > Marek reported that he saw an issue with the below snippet in that > timing measurements where off when loaded as unpriv while results > were reasonable when loaded as privileged: > > [...] > uint64_t a = bpf_ktime_get_ns(); > u

[PATCH bpf] bpf: fix sanitation rewrite in case of non-pointers

2019-03-01 Thread Daniel Borkmann
Marek reported that he saw an issue with the below snippet in that timing measurements where off when loaded as unpriv while results were reasonable when loaded as privileged: [...] uint64_t a = bpf_ktime_get_ns(); uint64_t b = bpf_ktime_get_ns(); uint64_t delta = b - a; if ((i