Re: [PATCH bpf] bpf: devmap: fix wrong interface selection in notifier_call

2018-10-24 Thread Taehee Yoo
Hi Daniel! On Wed, 24 Oct 2018 at 18:07, Daniel Borkmann wrote: > > [ +John ] > > On 10/22/2018 05:41 PM, Taehee Yoo wrote: > > The dev_map_notification() removes interface in devmap if > > unregistering interface's ifindex is same. > > But only checking ifindex is not enough because other netns

Re: [PATCH bpf] bpf: devmap: fix wrong interface selection in notifier_call

2018-10-24 Thread Daniel Borkmann
[ +John ] On 10/22/2018 05:41 PM, Taehee Yoo wrote: > The dev_map_notification() removes interface in devmap if > unregistering interface's ifindex is same. > But only checking ifindex is not enough because other netns can have > same ifindex. so that wrong interface selection could occurred. > He

[PATCH bpf] bpf: devmap: fix wrong interface selection in notifier_call

2018-10-22 Thread Taehee Yoo
The dev_map_notification() removes interface in devmap if unregistering interface's ifindex is same. But only checking ifindex is not enough because other netns can have same ifindex. so that wrong interface selection could occurred. Hence the net_eq() is needed. Fixes: 2ddf71e23cc2 ("net: add not