Re: [PATCH bpf] bpf: Fix clobbering of r2 in bpf_gen_ld_abs

2020-09-08 Thread Alexei Starovoitov
On Mon, Sep 7, 2020 at 3:04 PM Daniel Borkmann wrote: > > Bryce reported that he saw the following with: > > 0: r6 = r1 > 1: r1 = 12 > 2: r0 = *(u16 *)skb[r1] > > The xlated sequence was incorrectly clobbering r2 with pointer > value of r6 ... > > 0: (bf) r6 = r1 > 1: (b7) r1 = 12 >

[PATCH bpf] bpf: Fix clobbering of r2 in bpf_gen_ld_abs

2020-09-07 Thread Daniel Borkmann
Bryce reported that he saw the following with: 0: r6 = r1 1: r1 = 12 2: r0 = *(u16 *)skb[r1] The xlated sequence was incorrectly clobbering r2 with pointer value of r6 ... 0: (bf) r6 = r1 1: (b7) r1 = 12 2: (bf) r1 = r6 3: (bf) r2 = r1 4: (85) call bpf_skb_load_helper_16_no_ca