We will remove all the casting from void *.
Thanks
On 8/18/2017 8:03 AM, David Miller wrote:
> From: Stephen Hemminger
> Date: Thu, 17 Aug 2017 17:45:40 -0700
>
>> On Thu, 17 Aug 2017 19:52:42 +0800
>> Aviad Krawczyk wrote:
>>
>>> + nic_dev = (struct hinic_dev *)netdev_priv(netdev);
>>
>> Si
From: Stephen Hemminger
Date: Thu, 17 Aug 2017 17:45:40 -0700
> On Thu, 17 Aug 2017 19:52:42 +0800
> Aviad Krawczyk wrote:
>
>> +nic_dev = (struct hinic_dev *)netdev_priv(netdev);
>
> Since netdev_priv() returns void *, a cast is not necessary here.
Agreed.
From: Stephen Hemminger
Date: Thu, 17 Aug 2017 17:42:05 -0700
> Please drop these functions, they do nothing and are not used
> as stubs in any operations table.
It might have been helpful to scan the entire series to understand
why it looks this way.
He's building the driver up, one piece at a
On Thu, 17 Aug 2017 19:52:42 +0800
Aviad Krawczyk wrote:
> + nic_dev = (struct hinic_dev *)netdev_priv(netdev);
Sinc netdev_priv() returns void *, a cast is not necessary here.
On Thu, 17 Aug 2017 19:52:42 +0800
Aviad Krawczyk wrote:
> +
> +/**
> + * init_pfhwdev - Initialize the extended components of PF
> + * @pfhwdev: the HW device for PF
> + *
> + * Return 0 - success, negative - failure
> + **/
> +static int init_pfhwdev(struct hinic_pfhwdev *pfhwdev)
> +{
> +
Initialize hw interface as part of the nic initialization for accessing hw.
Signed-off-by: Aviad Krawczyk
Signed-off-by: Zhao Chen
---
Documentation/networking/hinic.txt | 125 ++
drivers/net/ethernet/Kconfig | 1 +
drivers/net/ethernet/Makefile
