Re: [PATCH V4] net: dsa: mt7530: Add of_node_put() before break and return statements

2020-08-25 Thread David Miller
From: Sumera Priyadarsini Date: Tue, 25 Aug 2020 01:33:11 +0530 > Every iteration of for_each_child_of_node() decrements > the reference count of the previous node, however when control > is transferred from the middle of the loop, as in the case of > a return or break or goto, there is no decrem

[PATCH V4] net: dsa: mt7530: Add of_node_put() before break and return statements

2020-08-24 Thread Sumera Priyadarsini
Every iteration of for_each_child_of_node() decrements the reference count of the previous node, however when control is transferred from the middle of the loop, as in the case of a return or break or goto, there is no decrement thus ultimately resulting in a memory leak. Fix a potential memory le