From: Aviad Krawczyk
Date: Tue, 8 Aug 2017 19:23:32 +0300
> Is it a new rule?
It's at least 10 years old.
> We can fix it, but I can look over the Linux Kernel source and there are
> a lot of examples that have the same problem.
Stop right there.
Just because there is code in the kernel with
Hi David,
Is it a new rule?
We can fix it, but I can look over the Linux Kernel source and there are
a lot of examples that have the same problem. I can see even code that inserted
to 4.10 with the same problem.
Thanks for your time and review,
Aviad
On 8/4/2017 1:35 AM, David Miller wrote:
> F
From: Aviad Krawczyk
Date: Thu, 3 Aug 2017 17:54:09 +0800
> +static int alloc_cmd_buf(struct hinic_api_cmd_chain *chain,
> + struct hinic_api_cmd_cell *cell, int cell_idx)
> +{
> + struct hinic_hwif *hwif = chain->hwif;
> + struct pci_dev *pdev = hwif->pdev;
> + s
Initialize api cmd resources as part of management initialization.
Signed-off-by: Aviad Krawczyk
Signed-off-by: Zhao Chen
---
drivers/net/ethernet/huawei/hinic/Makefile | 4 +-
.../net/ethernet/huawei/hinic/hinic_hw_api_cmd.c | 444 +
.../net/ethernet/huawei/hini