Re: [PATCH V3 net-next 01/15] net: introduce keepalive function in struct proto

2016-11-25 Thread David Miller
From: Ursula Braun Date: Thu, 24 Nov 2016 16:06:31 +0100 > diff --git a/net/ipv4/tcp_timer.c b/net/ipv4/tcp_timer.c > index 3ea1cf8..9b1602a 100644 > --- a/net/ipv4/tcp_timer.c > +++ b/net/ipv4/tcp_timer.c > @@ -617,6 +617,7 @@ void tcp_set_keepalive(struct sock *sk, int val) > else if (!va

[PATCH V3 net-next 01/15] net: introduce keepalive function in struct proto

2016-11-24 Thread Ursula Braun
Direct call of tcp_set_keepalive() function from protocol-agnostic sock_setsockopt() function in net/core/sock.c violates network layering. And newly introduced protocol (SMC-R) will need its own keepalive function. Therefore, add "keepalive" function pointer to "struct proto", and call it from soc