Re: [PATCH V3 net-next] ixgbe: Avoid unaligned access in ixgbe_atr() for LLC packets

2016-03-19 Thread Sowmini Varadhan
On (03/16/16 15:58), Jeff Kirsher wrote: > > This does not apply since Alex Duyck beat you to the fix.  Here is the > patch he submitted on 3/15 which corrects the issue.  So I am dropping > your patch from the queue. > That's weird because Alexander was reviewing my fix on the various lists yes

Re: [PATCH V3 net-next] ixgbe: Avoid unaligned access in ixgbe_atr() for LLC packets

2016-03-19 Thread Jeff Kirsher
On Mon, 2016-03-14 at 15:47 -0400, Sowmini Varadhan wrote: > > For LLC based protocols like lldp, stp etc., the ethernet header > is an 802.3 header with a h_proto that is not 0x800, 0x86dd, or > even 0x806.  In this world, the skb_network_header() points at > the DSAP/SSAP/..  and is not likely t

Re: [PATCH V3 net-next] ixgbe: Avoid unaligned access in ixgbe_atr() for LLC packets

2016-03-18 Thread Alexander Duyck
On Wed, Mar 16, 2016 at 4:01 PM, Sowmini Varadhan wrote: > On (03/16/16 15:58), Jeff Kirsher wrote: >> >> This does not apply since Alex Duyck beat you to the fix. Here is the >> patch he submitted on 3/15 which corrects the issue. So I am dropping >> your patch from the queue. >> > > That's wei

[PATCH V3 net-next] ixgbe: Avoid unaligned access in ixgbe_atr() for LLC packets

2016-03-14 Thread Sowmini Varadhan
For LLC based protocols like lldp, stp etc., the ethernet header is an 802.3 header with a h_proto that is not 0x800, 0x86dd, or even 0x806. In this world, the skb_network_header() points at the DSAP/SSAP/.. and is not likely to be NET_IP_ALIGNed in ixgbe_atr(). With LLC, drivers are not likely