Re: [PATCH V3] netfilter: h323: avoid potential attack

2016-02-01 Thread Eric Dumazet
On Mon, 2016-02-01 at 18:58 +0100, Pablo Neira Ayuso wrote: > On Fri, Jan 29, 2016 at 11:25:35AM +0800, Zhouyi Zhou wrote: > > I think hackers chould build a malicious h323 packet to overflow > > the pointer p which will panic during the memcpy(addr, p, len) > > For example, he may fabricate a very

Re: [PATCH V3] netfilter: h323: avoid potential attack

2016-02-01 Thread Pablo Neira Ayuso
On Fri, Jan 29, 2016 at 11:25:35AM +0800, Zhouyi Zhou wrote: > I think hackers chould build a malicious h323 packet to overflow > the pointer p which will panic during the memcpy(addr, p, len) > For example, he may fabricate a very large taddr->ipAddress.ip; > As suggested by Eric, this module is p

[PATCH V3] netfilter: h323: avoid potential attack

2016-01-28 Thread Zhouyi Zhou
I think hackers chould build a malicious h323 packet to overflow the pointer p which will panic during the memcpy(addr, p, len) For example, he may fabricate a very large taddr->ipAddress.ip; As suggested by Eric, this module is protected by a lock (nf_h323_lock) so adding a variable h323_buffer_va