Re: [PATCH V3] net: stmmac: socfpga: Remove re-registration of reset controller

2016-04-26 Thread Marek Vasut
On 04/26/2016 11:22 PM, Joachim Eastwood wrote: > On 26 April 2016 at 14:47, Marek Vasut wrote: >> On 04/26/2016 02:26 PM, Joachim Eastwood wrote: >>> On 26 April 2016 at 00:55, Marek Vasut wrote: On 04/25/2016 08:11 PM, Joachim Eastwood wrote: > On 21 April 2016 at 14:11, Marek Vasut w

Re: [PATCH V3] net: stmmac: socfpga: Remove re-registration of reset controller

2016-04-26 Thread Joachim Eastwood
On 26 April 2016 at 14:47, Marek Vasut wrote: > On 04/26/2016 02:26 PM, Joachim Eastwood wrote: >> On 26 April 2016 at 00:55, Marek Vasut wrote: >>> On 04/25/2016 08:11 PM, Joachim Eastwood wrote: On 21 April 2016 at 14:11, Marek Vasut wrote: > > Finally, plat_dat->exit and socfpga_

Re: [PATCH V3] net: stmmac: socfpga: Remove re-registration of reset controller

2016-04-26 Thread Marek Vasut
On 04/26/2016 02:26 PM, Joachim Eastwood wrote: > On 26 April 2016 at 00:55, Marek Vasut wrote: >> On 04/25/2016 08:11 PM, Joachim Eastwood wrote: >>> On 21 April 2016 at 14:11, Marek Vasut wrote: Finally, plat_dat->exit and socfpga_dwmac_exit() is no longer necessary, since the fu

Re: [PATCH V3] net: stmmac: socfpga: Remove re-registration of reset controller

2016-04-26 Thread Joachim Eastwood
On 26 April 2016 at 00:55, Marek Vasut wrote: > On 04/25/2016 08:11 PM, Joachim Eastwood wrote: >> On 21 April 2016 at 14:11, Marek Vasut wrote: >>> >>> Finally, plat_dat->exit and socfpga_dwmac_exit() is no longer necessary, >>> since the functionality is already performed by the stmmac core. >>

Re: [PATCH V3] net: stmmac: socfpga: Remove re-registration of reset controller

2016-04-25 Thread Marek Vasut
On 04/25/2016 08:11 PM, Joachim Eastwood wrote: > Hi Marek, Hi! > On 21 April 2016 at 14:11, Marek Vasut wrote: >> Both socfpga_dwmac_parse_data() in dwmac-socfpga.c and stmmac_dvr_probe() >> in stmmac_main.c functions call devm_reset_control_get() to register an >> reset controller for the stmm

Re: [PATCH V3] net: stmmac: socfpga: Remove re-registration of reset controller

2016-04-25 Thread Joachim Eastwood
Hi Marek, On 21 April 2016 at 14:11, Marek Vasut wrote: > Both socfpga_dwmac_parse_data() in dwmac-socfpga.c and stmmac_dvr_probe() > in stmmac_main.c functions call devm_reset_control_get() to register an > reset controller for the stmmac. This results in an attempt to register > two reset contr

Re: [PATCH V3] net: stmmac: socfpga: Remove re-registration of reset controller

2016-04-24 Thread David Miller
From: Marek Vasut Date: Thu, 21 Apr 2016 14:11:50 +0200 > Both socfpga_dwmac_parse_data() in dwmac-socfpga.c and stmmac_dvr_probe() > in stmmac_main.c functions call devm_reset_control_get() to register an > reset controller for the stmmac. This results in an attempt to register > two reset contr

Re: [PATCH V3] net: stmmac: socfpga: Remove re-registration of reset controller

2016-04-21 Thread Dinh Nguyen
On 04/21/2016 07:11 AM, Marek Vasut wrote: > Both socfpga_dwmac_parse_data() in dwmac-socfpga.c and stmmac_dvr_probe() > in stmmac_main.c functions call devm_reset_control_get() to register an > reset controller for the stmmac. This results in an attempt to register > two reset controllers for th

[PATCH V3] net: stmmac: socfpga: Remove re-registration of reset controller

2016-04-21 Thread Marek Vasut
Both socfpga_dwmac_parse_data() in dwmac-socfpga.c and stmmac_dvr_probe() in stmmac_main.c functions call devm_reset_control_get() to register an reset controller for the stmmac. This results in an attempt to register two reset controllers for the same non-shared reset line. The first attempt to r