Re: [PATCH V2 net-next 5/5] net: ena: ethtool: support set_channels callback

2019-10-03 Thread Jakub Kicinski
On Thu, 3 Oct 2019 15:32:33 +, Jubran, Samih wrote: > > > +int ena_update_queue_count(struct ena_adapter *adapter, u32 > > > new_channel_count) { > > > + struct ena_com_dev *ena_dev = adapter->ena_dev; > > > + bool dev_was_up; > > > + > > > + dev_was_up = test_bit(ENA_FLAG_DEV_UP, &adapter->fl

Re: [PATCH V2 net-next 5/5] net: ena: ethtool: support set_channels callback

2019-10-03 Thread Michal Kubecek
On Wed, Oct 02, 2019 at 01:11:32PM -0700, Jakub Kicinski wrote: > On Wed, 2 Oct 2019 11:20:52 +0300, same...@amazon.com wrote: > > + > > + new_channel_count = clamp_val(channels->tx_count, > > + ENA_MIN_NUM_IO_QUEUES, channels->max_tx); > > You should return an er

RE: [PATCH V2 net-next 5/5] net: ena: ethtool: support set_channels callback

2019-10-03 Thread Jubran, Samih
uori, > Anthony ; Bshara, Nafea ; > Tzalik, Guy ; Belgazal, Netanel > ; Saidi, Ali ; Herrenschmidt, > Benjamin ; Kiyanovski, Arthur > > Subject: Re: [PATCH V2 net-next 5/5] net: ena: ethtool: support > set_channels callback > > On Wed, 2 Oct 2019 11:20:52 +0300

Re: [PATCH V2 net-next 5/5] net: ena: ethtool: support set_channels callback

2019-10-02 Thread Jakub Kicinski
On Wed, 2 Oct 2019 11:20:52 +0300, same...@amazon.com wrote: > From: Sameeh Jubran > > Set channels callback enables the user to change the count of queues > used by the driver using ethtool. We decided to currently support only > equal number of rx and tx queues, this might change in the future.

[PATCH V2 net-next 5/5] net: ena: ethtool: support set_channels callback

2019-10-02 Thread sameehj
From: Sameeh Jubran Set channels callback enables the user to change the count of queues used by the driver using ethtool. We decided to currently support only equal number of rx and tx queues, this might change in the future. Also rename dev_up to dev_was_up in ena_update_queue_count() to make

[PATCH V2 net-next 5/5] net: ena: ethtool: support set_channels callback

2019-09-19 Thread sameehj
From: Sameeh Jubran Set channels callback enables the user to change the count of queues used by the driver using ethtool. We decided to currently support only equal number of rx and tx queues, this might change in the future. Also rename dev_up to dev_was_up in ena_update_queue_count() to make