Re: [PATCH RFC v2 net-next] rds-tcp: Take explicit refcounts on struct net

2017-03-02 Thread Sowmini Varadhan
On (03/02/17 11:07), Dmitry Vyukov wrote: > > The other 2 does not look like net-related, but you also mailed patch > "Cancel any pending connection attempts before taking down > connection", which looks like it should fix the other 2, right? no, that patch was still broken.. because, as you poin

Re: [PATCH RFC v2 net-next] rds-tcp: Take explicit refcounts on struct net

2017-03-02 Thread Dmitry Vyukov
On Tue, Feb 28, 2017 at 5:33 PM, Sowmini Varadhan wrote: > This is a test patch being supplied for a trial run on syzkaller. > > It's incorrect for the rds_connection to piggyback on the > sock_net() refcount for the netns because this gives rise to > a chicken-and-egg problem during rds_conn_dest

[PATCH RFC v2 net-next] rds-tcp: Take explicit refcounts on struct net

2017-03-01 Thread Sowmini Varadhan
This is a test patch being supplied for a trial run on syzkaller. It's incorrect for the rds_connection to piggyback on the sock_net() refcount for the netns because this gives rise to a chicken-and-egg problem during rds_conn_destroy. Instead explicitly take a ref on the net, and hold the netns d