Re: [PATCH RFC v2] mac80211: debugfs option to force TX status frames

2019-03-07 Thread ga58taw
On Thu, Mar 07, 2019 at 05:42:04PM +0200, Kalle Valo wrote: > > + len = scnprintf(buf, sizeof(buf), "%d\n", (int)local->force_tx_status); > > I wonder about the cast, is it guaranteed that a bool is always of the > same size as an int? Why is this a problem? If a bool is smaller than an int, the

Re: [PATCH RFC v2] mac80211: debugfs option to force TX status frames

2019-03-07 Thread Kalle Valo
Julius Niedworok writes: > At Technical University of Munich we use MAC 802.11 TX status frames to > perform several measurements in MAC 802.11 setups. > > With ath based drivers this was possible until commit d94a461d7a7df6 > ("ath9k: use ieee80211_tx_status_noskb where possible") as the driver

[PATCH RFC v2] mac80211: debugfs option to force TX status frames

2019-03-06 Thread Julius Niedworok
At Technical University of Munich we use MAC 802.11 TX status frames to perform several measurements in MAC 802.11 setups. With ath based drivers this was possible until commit d94a461d7a7df6 ("ath9k: use ieee80211_tx_status_noskb where possible") as the driver ignored the IEEE80211_TX_CTL_REQ_TX_