Re: [PATCH RFC net-next] net: core: Pass XPS select queue decision to skb_tx_hash

2016-03-31 Thread John Fastabend
On 16-03-30 11:30 AM, Saeed Mahameed wrote: > On Wed, Mar 30, 2016 at 8:04 PM, John Fastabend > wrote: >> >> OK, so let me see if I get this right now. This was the precedence >> before the patch in the normal no select queue case, >> >> (1) socket mapping sk_tx_queue_mapping iff !ooo_okay

Re: [PATCH RFC net-next] net: core: Pass XPS select queue decision to skb_tx_hash

2016-03-30 Thread Saeed Mahameed
On Wed, Mar 30, 2016 at 8:04 PM, John Fastabend wrote: > > OK, so let me see if I get this right now. This was the precedence > before the patch in the normal no select queue case, > > (1) socket mapping sk_tx_queue_mapping iff !ooo_okay > (2) xps > (3) skb->queue_mapping >

Re: [PATCH RFC net-next] net: core: Pass XPS select queue decision to skb_tx_hash

2016-03-30 Thread John Fastabend
On 16-03-30 06:23 AM, Saeed Mahameed wrote: > > > On 3/30/2016 3:18 AM, John Fastabend wrote: >> I would prefer to not have another strange quirk users have to >> remember in order to do tx classification. So with this change >> depending on the driver the queue selection precedence changes. >

Re: [PATCH RFC net-next] net: core: Pass XPS select queue decision to skb_tx_hash

2016-03-30 Thread Saeed Mahameed
On 3/30/2016 3:18 AM, John Fastabend wrote: I would prefer to not have another strange quirk users have to remember in order to do tx classification. So with this change depending on the driver the queue selection precedence changes. This change doesn't depend on the driver it affects all dri

Re: [PATCH RFC net-next] net: core: Pass XPS select queue decision to skb_tx_hash

2016-03-29 Thread John Fastabend
On 16-03-29 03:24 PM, Saeed Mahameed wrote: > Currently XPS select queue decision is final and overrides/ignores all other > select queue parameters such as QoS TC, RX recording. > > This patch makes get_xps_queue value as a hint for skb_tx_hash, which will > decide > whether to use this hint as

[PATCH RFC net-next] net: core: Pass XPS select queue decision to skb_tx_hash

2016-03-29 Thread Saeed Mahameed
Currently XPS select queue decision is final and overrides/ignores all other select queue parameters such as QoS TC, RX recording. This patch makes get_xps_queue value as a hint for skb_tx_hash, which will decide whether to use this hint as is or to tweak it a little to provide the correct TXQ.