Re: [PATCH RFC net-next] net: Assert napi_gro_cb size against skb->cb[]

2015-07-31 Thread Florian Fainelli
On 31/07/15 13:44, David Miller wrote: > From: Florian Westphal > Date: Fri, 31 Jul 2015 22:24:03 +0200 > >> Florian Fainelli wrote: >>> On 64-bits hosts, napi_gro_cb is 48 bytes, which is exactly the size of >>> skb->cb[], while on 32-bits hosts it is 36 bytes, but if it were to >>> grow, we wo

Re: [PATCH RFC net-next] net: Assert napi_gro_cb size against skb->cb[]

2015-07-31 Thread David Miller
From: Florian Westphal Date: Fri, 31 Jul 2015 22:24:03 +0200 > Florian Fainelli wrote: >> On 64-bits hosts, napi_gro_cb is 48 bytes, which is exactly the size of >> skb->cb[], while on 32-bits hosts it is 36 bytes, but if it were to >> grow, we would not be catching a size inflation as we should

Re: [PATCH RFC net-next] net: Assert napi_gro_cb size against skb->cb[]

2015-07-31 Thread Florian Westphal
Florian Fainelli wrote: > On 64-bits hosts, napi_gro_cb is 48 bytes, which is exactly the size of > skb->cb[], while on 32-bits hosts it is 36 bytes, but if it were to > grow, we would not be catching a size inflation as we should. > --- > net/core/dev.c | 2 ++ > 1 file changed, 2 insertions(+)

Re: [PATCH RFC net-next] net: Assert napi_gro_cb size against skb->cb[]

2015-07-31 Thread Tom Herbert
On Fri, Jul 31, 2015 at 11:51 AM, Florian Fainelli wrote: > On 64-bits hosts, napi_gro_cb is 48 bytes, which is exactly the size of > skb->cb[], while on 32-bits hosts it is 36 bytes, but if it were to > grow, we would not be catching a size inflation as we should. > > Make sure that we have enoug

[PATCH RFC net-next] net: Assert napi_gro_cb size against skb->cb[]

2015-07-31 Thread Florian Fainelli
On 64-bits hosts, napi_gro_cb is 48 bytes, which is exactly the size of skb->cb[], while on 32-bits hosts it is 36 bytes, but if it were to grow, we would not be catching a size inflation as we should. Make sure that we have enough room for a napi_gro_cb to be hosted in skb->cb[], and put this bui