Re: [PATCH RFC net-next] mlx5: fix for crash on net-next

2021-02-23 Thread Jesper Dangaard Brouer
On Tue, 23 Feb 2021 10:28:35 +0200 Tariq Toukan wrote: > On 2/22/2021 9:50 PM, Jesper Dangaard Brouer wrote: > > Net-next at commit d310ec03a34e ("Merge tag 'perf-core-2021-02-17') > > > > There is a divide error in drivers/net/ethernet/mellanox/mlx5/core/en_tx.c > > where it seems that num_tc_x

Re: [PATCH RFC net-next] mlx5: fix for crash on net-next

2021-02-23 Thread Tariq Toukan
On 2/22/2021 9:50 PM, Jesper Dangaard Brouer wrote: Net-next at commit d310ec03a34e ("Merge tag 'perf-core-2021-02-17') There is a divide error in drivers/net/ethernet/mellanox/mlx5/core/en_tx.c where it seems that num_tc_x_num_ch can become zero in a modulo operation: if (unlikely(t

[PATCH RFC net-next] mlx5: fix for crash on net-next

2021-02-22 Thread Jesper Dangaard Brouer
Net-next at commit d310ec03a34e ("Merge tag 'perf-core-2021-02-17') There is a divide error in drivers/net/ethernet/mellanox/mlx5/core/en_tx.c where it seems that num_tc_x_num_ch can become zero in a modulo operation: if (unlikely(txq_ix >= num_tc_x_num_ch)) txq_ix %= num_