Re: [PATCH RFC net] net/mlx5e: Add preemption enable/disable around TC statistics upcall

2017-02-12 Thread Or Gerlitz
On Fri, Feb 10, 2017 at 8:14 PM, Jakub Kicinski wrote: > On Fri, 10 Feb 2017 18:21:25 +0200, Or Gerlitz wrote: >> On Fri, Feb 10, 2017 at 3:34 AM, Jakub Kicinski wrote: >> > On Thu, 9 Feb 2017 17:38:43 +0200, Or Gerlitz wrote: >> >> Running with CONFIG_PREEMPT set, I get a >> >> >> >> BUG: using

Re: [PATCH RFC net] net/mlx5e: Add preemption enable/disable around TC statistics upcall

2017-02-10 Thread Jakub Kicinski
On Fri, 10 Feb 2017 18:21:25 +0200, Or Gerlitz wrote: > On Fri, Feb 10, 2017 at 3:34 AM, Jakub Kicinski wrote: > > On Thu, 9 Feb 2017 17:38:43 +0200, Or Gerlitz wrote: > >> Running with CONFIG_PREEMPT set, I get a > >> > >> BUG: using smp_processor_id() in preemptible [] code: tc/3793 >

Re: [PATCH RFC net] net/mlx5e: Add preemption enable/disable around TC statistics upcall

2017-02-10 Thread Or Gerlitz
On Fri, Feb 10, 2017 at 3:34 AM, Jakub Kicinski wrote: > On Thu, 9 Feb 2017 17:38:43 +0200, Or Gerlitz wrote: >> Running with CONFIG_PREEMPT set, I get a >> >> BUG: using smp_processor_id() in preemptible [] code: tc/3793 >> >> asserion from the TC action (mirred) stats_update callback, w

Re: [PATCH RFC net] net/mlx5e: Add preemption enable/disable around TC statistics upcall

2017-02-09 Thread Jakub Kicinski
On Thu, 9 Feb 2017 17:38:43 +0200, Or Gerlitz wrote: > Running with CONFIG_PREEMPT set, I get a > > BUG: using smp_processor_id() in preemptible [] code: tc/3793 > > asserion from the TC action (mirred) stats_update callback, when the do > > _bstats_cpu_update(this_cpu_ptr(a->cpu_

[PATCH RFC net] net/mlx5e: Add preemption enable/disable around TC statistics upcall

2017-02-09 Thread Or Gerlitz
Running with CONFIG_PREEMPT set, I get a BUG: using smp_processor_id() in preemptible [] code: tc/3793 asserion from the TC action (mirred) stats_update callback, when the do _bstats_cpu_update(this_cpu_ptr(a->cpu_bstats), bytes, packets) As done by commit 66860be "nfp: bpf: all