Re: [PATCH RFC net] neigh: do not modify unlinked entries

2015-06-21 Thread David Miller
From: Julian Anastasov Date: Tue, 16 Jun 2015 22:56:39 +0300 > The lockless lookups can return entry that is unlinked. > Sometimes they get reference before last neigh_cleanup_and_release, > sometimes they do not need reference. Later, any > modification attempts may result in the following probl

Re: [PATCH RFC net] neigh: do not modify unlinked entries

2015-06-19 Thread Julian Anastasov
Hello, On Fri, 19 Jun 2015, YOSHIFUJI Hideaki/吉藤英明 wrote: > Should we always drop the packet here since it is > already dead, shouldn't we? It can be a NETDEV_CHANGEADDR event, eth_header() will build valid header. It can be some race condition with neigh_forced_gc and neigh_per

Re: [PATCH RFC net] neigh: do not modify unlinked entries

2015-06-19 Thread YOSHIFUJI Hideaki/吉藤英明
Hi, Julian Anastasov wrote: > The lockless lookups can return entry that is unlinked. > Sometimes they get reference before last neigh_cleanup_and_release, > sometimes they do not need reference. Later, any > modification attempts may result in the following problems: > > 1. entry is not destroye

Re: [PATCH RFC net] neigh: do not modify unlinked entries

2015-06-18 Thread Eric Dumazet
On Tue, 2015-06-16 at 22:56 +0300, Julian Anastasov wrote: > The lockless lookups can return entry that is unlinked. > Sometimes they get reference before last neigh_cleanup_and_release, > sometimes they do not need reference. Later, any > modification attempts may result in the following problems:

[PATCH RFC net] neigh: do not modify unlinked entries

2015-06-16 Thread Julian Anastasov
The lockless lookups can return entry that is unlinked. Sometimes they get reference before last neigh_cleanup_and_release, sometimes they do not need reference. Later, any modification attempts may result in the following problems: 1. entry is not destroyed immediately because neigh_update can st