Re: [PATCH RFC 1/2] virtio-net: bql support

2019-01-17 Thread Jason Wang
On 2019/1/2 下午9:54, Michael S. Tsirkin wrote: On Wed, Jan 02, 2019 at 11:30:11AM +0800, Jason Wang wrote: On 2018/12/31 上午2:48, Michael S. Tsirkin wrote: On Thu, Dec 27, 2018 at 06:04:53PM +0800, Jason Wang wrote: On 2018/12/26 下午11:22, Michael S. Tsirkin wrote: On Thu, Dec 06, 2018 at 04:1

Re: [PATCH RFC 1/2] virtio-net: bql support

2019-01-08 Thread Jason Wang
On 2019/1/7 下午10:19, Michael S. Tsirkin wrote: On Mon, Jan 07, 2019 at 02:31:47PM +0800, Jason Wang wrote: On 2019/1/7 下午12:01, Michael S. Tsirkin wrote: On Mon, Jan 07, 2019 at 11:51:55AM +0800, Jason Wang wrote: On 2019/1/7 上午11:17, Michael S. Tsirkin wrote: On Mon, Jan 07, 2019 at 10:14:

Re: [PATCH RFC 1/2] virtio-net: bql support

2019-01-07 Thread Michael S. Tsirkin
On Mon, Jan 07, 2019 at 02:31:47PM +0800, Jason Wang wrote: > > On 2019/1/7 下午12:01, Michael S. Tsirkin wrote: > > On Mon, Jan 07, 2019 at 11:51:55AM +0800, Jason Wang wrote: > > > On 2019/1/7 上午11:17, Michael S. Tsirkin wrote: > > > > On Mon, Jan 07, 2019 at 10:14:37AM +0800, Jason Wang wrote: >

Re: [PATCH RFC 1/2] virtio-net: bql support

2019-01-06 Thread Jason Wang
On 2019/1/7 下午12:01, Michael S. Tsirkin wrote: On Mon, Jan 07, 2019 at 11:51:55AM +0800, Jason Wang wrote: On 2019/1/7 上午11:17, Michael S. Tsirkin wrote: On Mon, Jan 07, 2019 at 10:14:37AM +0800, Jason Wang wrote: On 2019/1/2 下午9:59, Michael S. Tsirkin wrote: On Wed, Jan 02, 2019 at 11:28:4

Re: [PATCH RFC 1/2] virtio-net: bql support

2019-01-06 Thread Michael S. Tsirkin
On Mon, Jan 07, 2019 at 11:51:55AM +0800, Jason Wang wrote: > > On 2019/1/7 上午11:17, Michael S. Tsirkin wrote: > > On Mon, Jan 07, 2019 at 10:14:37AM +0800, Jason Wang wrote: > > > On 2019/1/2 下午9:59, Michael S. Tsirkin wrote: > > > > On Wed, Jan 02, 2019 at 11:28:43AM +0800, Jason Wang wrote: > >

Re: [PATCH RFC 1/2] virtio-net: bql support

2019-01-06 Thread Jason Wang
On 2019/1/7 上午11:17, Michael S. Tsirkin wrote: On Mon, Jan 07, 2019 at 10:14:37AM +0800, Jason Wang wrote: On 2019/1/2 下午9:59, Michael S. Tsirkin wrote: On Wed, Jan 02, 2019 at 11:28:43AM +0800, Jason Wang wrote: On 2018/12/31 上午2:45, Michael S. Tsirkin wrote: On Thu, Dec 27, 2018 at 06:00:

Re: [PATCH RFC 1/2] virtio-net: bql support

2019-01-06 Thread Michael S. Tsirkin
On Mon, Jan 07, 2019 at 10:14:37AM +0800, Jason Wang wrote: > > On 2019/1/2 下午9:59, Michael S. Tsirkin wrote: > > On Wed, Jan 02, 2019 at 11:28:43AM +0800, Jason Wang wrote: > > > On 2018/12/31 上午2:45, Michael S. Tsirkin wrote: > > > > On Thu, Dec 27, 2018 at 06:00:36PM +0800, Jason Wang wrote: >

Re: [PATCH RFC 1/2] virtio-net: bql support

2019-01-06 Thread Jason Wang
On 2019/1/2 下午9:59, Michael S. Tsirkin wrote: On Wed, Jan 02, 2019 at 11:28:43AM +0800, Jason Wang wrote: On 2018/12/31 上午2:45, Michael S. Tsirkin wrote: On Thu, Dec 27, 2018 at 06:00:36PM +0800, Jason Wang wrote: On 2018/12/26 下午11:19, Michael S. Tsirkin wrote: On Thu, Dec 06, 2018 at 04:1

Re: [PATCH RFC 1/2] virtio-net: bql support

2019-01-02 Thread Michael S. Tsirkin
On Wed, Jan 02, 2019 at 11:28:43AM +0800, Jason Wang wrote: > > On 2018/12/31 上午2:45, Michael S. Tsirkin wrote: > > On Thu, Dec 27, 2018 at 06:00:36PM +0800, Jason Wang wrote: > > > On 2018/12/26 下午11:19, Michael S. Tsirkin wrote: > > > > On Thu, Dec 06, 2018 at 04:17:36PM +0800, Jason Wang wrote:

Re: [PATCH RFC 1/2] virtio-net: bql support

2019-01-02 Thread Michael S. Tsirkin
On Wed, Jan 02, 2019 at 11:30:11AM +0800, Jason Wang wrote: > > On 2018/12/31 上午2:48, Michael S. Tsirkin wrote: > > On Thu, Dec 27, 2018 at 06:04:53PM +0800, Jason Wang wrote: > > > On 2018/12/26 下午11:22, Michael S. Tsirkin wrote: > > > > On Thu, Dec 06, 2018 at 04:17:36PM +0800, Jason Wang wrote:

Re: [PATCH RFC 1/2] virtio-net: bql support

2019-01-01 Thread Jason Wang
On 2018/12/31 上午2:48, Michael S. Tsirkin wrote: On Thu, Dec 27, 2018 at 06:04:53PM +0800, Jason Wang wrote: On 2018/12/26 下午11:22, Michael S. Tsirkin wrote: On Thu, Dec 06, 2018 at 04:17:36PM +0800, Jason Wang wrote: On 2018/12/6 上午6:54, Michael S. Tsirkin wrote: When use_napi is set, let's

Re: [PATCH RFC 1/2] virtio-net: bql support

2019-01-01 Thread Jason Wang
On 2018/12/31 上午2:45, Michael S. Tsirkin wrote: On Thu, Dec 27, 2018 at 06:00:36PM +0800, Jason Wang wrote: On 2018/12/26 下午11:19, Michael S. Tsirkin wrote: On Thu, Dec 06, 2018 at 04:17:36PM +0800, Jason Wang wrote: On 2018/12/6 上午6:54, Michael S. Tsirkin wrote: When use_napi is set, let's

Re: [PATCH RFC 1/2] virtio-net: bql support

2018-12-30 Thread Michael S. Tsirkin
On Thu, Dec 27, 2018 at 06:04:53PM +0800, Jason Wang wrote: > > On 2018/12/26 下午11:22, Michael S. Tsirkin wrote: > > On Thu, Dec 06, 2018 at 04:17:36PM +0800, Jason Wang wrote: > > > On 2018/12/6 上午6:54, Michael S. Tsirkin wrote: > > > > When use_napi is set, let's enable BQLs. Note: some of the

Re: [PATCH RFC 1/2] virtio-net: bql support

2018-12-30 Thread Michael S. Tsirkin
On Thu, Dec 27, 2018 at 06:00:36PM +0800, Jason Wang wrote: > > On 2018/12/26 下午11:19, Michael S. Tsirkin wrote: > > On Thu, Dec 06, 2018 at 04:17:36PM +0800, Jason Wang wrote: > > > On 2018/12/6 上午6:54, Michael S. Tsirkin wrote: > > > > When use_napi is set, let's enable BQLs. Note: some of the

Re: [PATCH RFC 1/2] virtio-net: bql support

2018-12-27 Thread Jason Wang
On 2018/12/26 下午11:22, Michael S. Tsirkin wrote: On Thu, Dec 06, 2018 at 04:17:36PM +0800, Jason Wang wrote: On 2018/12/6 上午6:54, Michael S. Tsirkin wrote: When use_napi is set, let's enable BQLs. Note: some of the issues are similar to wifi. It's worth considering whether something similar

Re: [PATCH RFC 1/2] virtio-net: bql support

2018-12-27 Thread Jason Wang
On 2018/12/26 下午11:19, Michael S. Tsirkin wrote: On Thu, Dec 06, 2018 at 04:17:36PM +0800, Jason Wang wrote: On 2018/12/6 上午6:54, Michael S. Tsirkin wrote: When use_napi is set, let's enable BQLs. Note: some of the issues are similar to wifi. It's worth considering whether something similar

Re: [PATCH RFC 1/2] virtio-net: bql support

2018-12-27 Thread Jason Wang
On 2018/12/26 下午11:15, Michael S. Tsirkin wrote: On Thu, Dec 06, 2018 at 04:17:36PM +0800, Jason Wang wrote: On 2018/12/6 上午6:54, Michael S. Tsirkin wrote: When use_napi is set, let's enable BQLs. Note: some of the issues are similar to wifi. It's worth considering whether something similar

Re: [PATCH RFC 1/2] virtio-net: bql support

2018-12-26 Thread Michael S. Tsirkin
On Thu, Dec 06, 2018 at 04:17:36PM +0800, Jason Wang wrote: > > On 2018/12/6 上午6:54, Michael S. Tsirkin wrote: > > When use_napi is set, let's enable BQLs. Note: some of the issues are > > similar to wifi. It's worth considering whether something similar to > > commit 36148c2bbfbe ("mac80211: Ad

Re: [PATCH RFC 1/2] virtio-net: bql support

2018-12-26 Thread Michael S. Tsirkin
On Thu, Dec 06, 2018 at 04:17:36PM +0800, Jason Wang wrote: > > On 2018/12/6 上午6:54, Michael S. Tsirkin wrote: > > When use_napi is set, let's enable BQLs. Note: some of the issues are > > similar to wifi. It's worth considering whether something similar to > > commit 36148c2bbfbe ("mac80211: Ad

Re: [PATCH RFC 1/2] virtio-net: bql support

2018-12-26 Thread Michael S. Tsirkin
On Thu, Dec 06, 2018 at 04:17:36PM +0800, Jason Wang wrote: > > On 2018/12/6 上午6:54, Michael S. Tsirkin wrote: > > When use_napi is set, let's enable BQLs. Note: some of the issues are > > similar to wifi. It's worth considering whether something similar to > > commit 36148c2bbfbe ("mac80211: Ad

Re: [PATCH RFC 1/2] virtio-net: bql support

2018-12-06 Thread Jason Wang
On 2018/12/6 下午4:17, Jason Wang wrote: On 2018/12/6 上午6:54, Michael S. Tsirkin wrote: When use_napi is set, let's enable BQLs. Note: some of the issues are similar to wifi.  It's worth considering whether something similar to commit 36148c2bbfbe ("mac80211: Adjust TSQ pacing shift") might be b

Re: [PATCH RFC 1/2] virtio-net: bql support

2018-12-06 Thread Jason Wang
On 2018/12/6 上午6:54, Michael S. Tsirkin wrote: When use_napi is set, let's enable BQLs. Note: some of the issues are similar to wifi. It's worth considering whether something similar to commit 36148c2bbfbe ("mac80211: Adjust TSQ pacing shift") might be benefitial. I've played a similar pat

[PATCH RFC 1/2] virtio-net: bql support

2018-12-05 Thread Michael S. Tsirkin
When use_napi is set, let's enable BQLs. Note: some of the issues are similar to wifi. It's worth considering whether something similar to commit 36148c2bbfbe ("mac80211: Adjust TSQ pacing shift") might be benefitial. Signed-off-by: Michael S. Tsirkin --- drivers/net/virtio_net.c | 27