Re: [PATCH RFC 0/5] net/sched: validate the control action with all the other parameters

2019-02-19 Thread Davide Caratti
On Mon, 2019-02-18 at 22:42 -0800, Cong Wang wrote: > On Fri, Feb 15, 2019 at 3:06 PM Davide Caratti wrote: > > currently, the kernel checks for bad values of the control action in > > tcf_action_init_1(), after a successful call to the action's init() > > function. This causes three bad behaviors

Re: [PATCH RFC 0/5] net/sched: validate the control action with all the other parameters

2019-02-18 Thread Cong Wang
On Fri, Feb 15, 2019 at 3:06 PM Davide Caratti wrote: > > currently, the kernel checks for bad values of the control action in > tcf_action_init_1(), after a successful call to the action's init() > function. This causes three bad behaviors: Yeah, I have been complaining about this for a long tim

[PATCH RFC 0/5] net/sched: validate the control action with all the other parameters

2019-02-15 Thread Davide Caratti
currently, the kernel checks for bad values of the control action in tcf_action_init_1(), after a successful call to the action's init() function. This causes three bad behaviors: 1. the "half configuration" if the action is overwritten, the new configuration data are applied successfully