Re: [PATCH RESEND net-next 0/2] ntuple filters with RSS

2018-03-07 Thread David Miller
From: Edward Cree Date: Wed, 7 Mar 2018 15:40:39 + > On 07/03/18 15:24, David Miller wrote: >> Ok. >> >> Since nobody is really working on the ethtool --> devlink/netlink conversion, >> it really isn't reasonable for me to block useful changes like your's. >> >> So please resubmit this series

Re: [PATCH RESEND net-next 0/2] ntuple filters with RSS

2018-03-07 Thread Edward Cree
On 07/03/18 15:24, David Miller wrote: > Ok. > > Since nobody is really working on the ethtool --> devlink/netlink conversion, > it really isn't reasonable for me to block useful changes like your's. > > So please resubmit this series and I will apply it. > > Thanks. Ok, thanks.  Should I stick wit

Re: [PATCH RESEND net-next 0/2] ntuple filters with RSS

2018-03-07 Thread David Miller
From: Edward Cree Date: Fri, 2 Mar 2018 16:01:47 + > On 01/03/18 18:36, David Miller wrote: >> We really should have the ethtool interfaces under deep freeze until we >> convert it to netlink or similar. >> Second, this is a real hackish way to extend ethtool with new >> semantics.  A structu

Re: [PATCH RESEND net-next 0/2] ntuple filters with RSS

2018-03-02 Thread Alexander Duyck
On Fri, Mar 2, 2018 at 10:55 AM, Jakub Kicinski wrote: > On Fri, 2 Mar 2018 15:24:29 +, Edward Cree wrote: >> On Tue, Feb 27, 2018 at 3:47 PM, Jakub Kicinski wrote: >> >> > Please, let's stop extending ethtool_rx_flow APIs. I bit my tongue >> > when Intel was adding their "redirection to VF"

Re: [PATCH RESEND net-next 0/2] ntuple filters with RSS

2018-03-02 Thread Jakub Kicinski
On Fri, 2 Mar 2018 15:24:29 +, Edward Cree wrote: > On Tue, Feb 27, 2018 at 3:47 PM, Jakub Kicinski wrote: > > > Please, let's stop extending ethtool_rx_flow APIs. I bit my tongue > > when Intel was adding their "redirection to VF" based on ethtool ntuples > > and look now they're adding the

Re: [PATCH RESEND net-next 0/2] ntuple filters with RSS

2018-03-02 Thread David Riddoch
Lastly, there has been feedback asking how practical and useful this facility actually is, and you must address that. According to our marketing folks, there is end-user demand for this feature  or something like it. The main benefit comes on numa systems, when you have high throughput applic

Re: [PATCH RESEND net-next 0/2] ntuple filters with RSS

2018-03-02 Thread Edward Cree
On 01/03/18 18:36, David Miller wrote: > We really should have the ethtool interfaces under deep freeze until we > convert it to netlink or similar. > Second, this is a real hackish way to extend ethtool with new > semantics.  A structure changes layout based upon a flag bit setting > in an earlier

Re: [PATCH RESEND net-next 0/2] ntuple filters with RSS

2018-03-02 Thread Edward Cree
On Tue, Feb 27, 2018 at 3:47 PM, Jakub Kicinski wrote: > Please, let's stop extending ethtool_rx_flow APIs. I bit my tongue > when Intel was adding their "redirection to VF" based on ethtool ntuples > and look now they're adding the same functionality with flower :| And > wonder how to handle t

Re: [PATCH RESEND net-next 0/2] ntuple filters with RSS

2018-03-01 Thread David Miller
From: Edward Cree Date: Tue, 27 Feb 2018 17:59:12 + > This series introduces the ability to mark an ethtool steering filter to use > RSS spreading, and the ability to create and configure multiple RSS contexts > with different indirection tables, hash keys, and hash fields. > An implementat

Re: [PATCH RESEND net-next 0/2] ntuple filters with RSS

2018-02-27 Thread Alexander Duyck
On Tue, Feb 27, 2018 at 3:47 PM, Jakub Kicinski wrote: > On Tue, 27 Feb 2018 17:59:12 +, Edward Cree wrote: >> This series introduces the ability to mark an ethtool steering filter to use >> RSS spreading, and the ability to create and configure multiple RSS contexts >> with different indire

Re: [PATCH RESEND net-next 0/2] ntuple filters with RSS

2018-02-27 Thread Jakub Kicinski
On Tue, 27 Feb 2018 17:59:12 +, Edward Cree wrote: > This series introduces the ability to mark an ethtool steering filter to use > RSS spreading, and the ability to create and configure multiple RSS contexts > with different indirection tables, hash keys, and hash fields. > An implementation

Re: [PATCH RESEND net-next 0/2] ntuple filters with RSS

2018-02-27 Thread John W. Linville
On Tue, Feb 27, 2018 at 05:55:51PM +, Edward Cree wrote: > On 27/02/18 17:38, David Miller wrote: > > The problem is there are syntax errors in your email headers. > > > > Any time a person's name contains a special character like ".", > > that entire string must be enclosed in double quotes. >

[PATCH RESEND net-next 0/2] ntuple filters with RSS

2018-02-27 Thread Edward Cree
This series introduces the ability to mark an ethtool steering filter to use RSS spreading, and the ability to create and configure multiple RSS contexts with different indirection tables, hash keys, and hash fields. An implementation for the sfc driver (for 7000-series and later SFC NICs) is in

Re: [PATCH RESEND net-next 0/2] ntuple filters with RSS

2018-02-27 Thread Edward Cree
On 27/02/18 17:38, David Miller wrote: > The problem is there are syntax errors in your email headers. > > Any time a person's name contains a special character like ".", > that entire string must be enclosed in double quotes. > > This is the case for "John W. Linville" so please add proper > quote

Re: [PATCH RESEND net-next 0/2] ntuple filters with RSS

2018-02-27 Thread David Miller
Edward, none of these postings are making it to the list. The problem is there are syntax errors in your email headers. Any time a person's name contains a special character like ".", that entire string must be enclosed in double quotes. This is the case for "John W. Linville" so please add pro