Re: [PATCH 9/9] fix sparse warnings

2008-01-14 Thread Eric Dumazet
Robert Olsson a écrit : Thanks for hacking and improving and the trie... another idea that could be also tested. If we look into routing table we see that most leafs only has one prefix Main: Aver depth: 2.57 Max depth: 7 Leaves: 231173 ip route | wc -

Re: [PATCH 9/9] fix sparse warnings

2008-01-14 Thread Robert Olsson
Eric Dumazet writes: > > Thats 231173/241649 = 96% with the current Internet routing. > > > > How about if would have a fastpath and store one entry direct in the > > leaf struct this to avoid loading the leaf_info list in most cases? > > > > One could believe that both lookup and dump cou

Re: [PATCH 9/9] fix sparse warnings

2008-01-14 Thread Robert Olsson
Thanks for hacking and improving and the trie... another idea that could be also tested. If we look into routing table we see that most leafs only has one prefix Main: Aver depth: 2.57 Max depth: 7 Leaves: 231173 ip route | wc -l 241649 Thats 231173/24

Re: [PATCH 9/9] fix sparse warnings

2008-01-12 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Sat, 12 Jan 2008 13:09:46 -0800 > On Sat, 12 Jan 2008 12:16:13 +0100 > Eric Dumazet <[EMAIL PROTECTED]> wrote: > > > [FIB]: Reduce text size of net/ipv4/fib_trie.o > > > > In struct tnode, we use two fields of 5 bits for 'pos' and 'bits'. > > Swi

Re: [PATCH 9/9] fix sparse warnings

2008-01-12 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Fri, 11 Jan 2008 22:45:22 -0800 > Make FIB TRIE go through sparse checker without warnings. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Also applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the

Re: [PATCH 9/9] fix sparse warnings

2008-01-12 Thread Stephen Hemminger
On Sat, 12 Jan 2008 12:16:13 +0100 Eric Dumazet <[EMAIL PROTECTED]> wrote: > Stephen Hemminger a écrit : > > Make FIB TRIE go through sparse checker without warnings. > > > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> > > Hi Stephen > > While reviewing your patches (and fib code) I ha

Re: [PATCH 9/9] fix sparse warnings

2008-01-12 Thread Stephen Hemminger
On Sat, 12 Jan 2008 12:16:13 +0100 Eric Dumazet <[EMAIL PROTECTED]> wrote: > Stephen Hemminger a écrit : > > Make FIB TRIE go through sparse checker without warnings. > > > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> > > Hi Stephen > > While reviewing your patches (and fib code) I ha

Re: [PATCH 9/9] fix sparse warnings

2008-01-12 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Sat, 12 Jan 2008 12:16:13 +0100 > We could use a better scheme with an extra indirection. Unfortunately, indirection will likely have a negative impact upon performance. We go only as fast as the number of memory references made by this code. > 3

Re: [PATCH 9/9] fix sparse warnings

2008-01-12 Thread Eric Dumazet
Stephen Hemminger a écrit : Make FIB TRIE go through sparse checker without warnings. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Hi Stephen While reviewing your patches (and fib code) I had some questions : 1) I was wondering isn't trie_collect_stats() a potential cpu hog (big late

[PATCH 9/9] fix sparse warnings

2008-01-11 Thread Stephen Hemminger
Make FIB TRIE go through sparse checker without warnings. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/net/ipv4/fib_trie.c 2008-01-11 22:35:37.0 -0800 +++ b/net/ipv4/fib_trie.c 2008-01-11 22:41:57.0 -0800 @@ -653,7 +653,6 @@ static struct node *resize(str