Re: [PATCH 6/6] netlink: add infrastructure to expose policies to userspace

2019-04-28 Thread Johannes Berg
On Sat, 2019-04-27 at 13:25 +0200, Pablo Neira Ayuso wrote: > > > Take IFLA_AF_SPEC for example. To validate that, we end up calling into > > validate_link_af() which is defined in IPv4 and IPv6, rather than having > > the inet_af_policy/inet6_af_policy available and doing it in the caller > > (al

Re: [PATCH 6/6] netlink: add infrastructure to expose policies to userspace

2019-04-27 Thread Pablo Neira Ayuso
On Fri, Apr 26, 2019 at 09:22:20PM +0200, Johannes Berg wrote: > On Fri, 2019-04-26 at 20:21 +0200, Pablo Neira Ayuso wrote: > > On Fri, Apr 26, 2019 at 02:13:06PM +0200, Johannes Berg wrote: > > > diff --git a/include/uapi/linux/genetlink.h > > > b/include/uapi/linux/genetlink.h > > > index 877f7

Re: [PATCH 6/6] netlink: add infrastructure to expose policies to userspace

2019-04-26 Thread Johannes Berg
On Fri, 2019-04-26 at 20:21 +0200, Pablo Neira Ayuso wrote: > On Fri, Apr 26, 2019 at 02:13:06PM +0200, Johannes Berg wrote: > > diff --git a/include/uapi/linux/genetlink.h b/include/uapi/linux/genetlink.h > > index 877f7fa95466..9c0636ec2286 100644 > > --- a/include/uapi/linux/genetlink.h > > +++

Re: [PATCH 6/6] netlink: add infrastructure to expose policies to userspace

2019-04-26 Thread Pablo Neira Ayuso
On Fri, Apr 26, 2019 at 02:13:06PM +0200, Johannes Berg wrote: > diff --git a/include/uapi/linux/genetlink.h b/include/uapi/linux/genetlink.h > index 877f7fa95466..9c0636ec2286 100644 > --- a/include/uapi/linux/genetlink.h > +++ b/include/uapi/linux/genetlink.h > @@ -48,6 +48,7 @@ enum { > CT

[PATCH 6/6] netlink: add infrastructure to expose policies to userspace

2019-04-26 Thread Johannes Berg
From: Johannes Berg Add, and use in generic netlink, helpers to dump out a netlink policy to userspace, including all the range validation data, nested policies etc. This lets userspace discover what the kernel understands. For families/commands other than generic netlink, the helpers need to b