[PATCH 5/9] sit: refactor ipip6_tunnel_ioctl

2020-05-19 Thread Christoph Hellwig
Split the ioctl handler into one function per command instead of having a all the logic sit in one giant switch statement. Signed-off-by: Christoph Hellwig --- net/ipv6/sit.c | 368 - 1 file changed, 210 insertions(+), 158 deletions(-) diff --git

Re: [PATCH 5/9] sit: refactor ipip6_tunnel_ioctl

2020-05-18 Thread Jakub Kicinski
On Mon, 18 May 2020 18:47:25 +0200 Christoph Hellwig wrote: > On Mon, May 18, 2020 at 09:43:56AM -0700, Jakub Kicinski wrote: > > On Mon, 18 May 2020 13:46:51 +0200 Christoph Hellwig wrote: > > > Split the ioctl handler into one function per command instead of having > > > a all the logic sit in

Re: [PATCH 5/9] sit: refactor ipip6_tunnel_ioctl

2020-05-18 Thread Christoph Hellwig
On Mon, May 18, 2020 at 09:43:56AM -0700, Jakub Kicinski wrote: > On Mon, 18 May 2020 13:46:51 +0200 Christoph Hellwig wrote: > > Split the ioctl handler into one function per command instead of having > > a all the logic sit in one giant switch statement. > > > > Signed-off-by: Christoph Hellwig

Re: [PATCH 5/9] sit: refactor ipip6_tunnel_ioctl

2020-05-18 Thread Jakub Kicinski
On Mon, 18 May 2020 13:46:51 +0200 Christoph Hellwig wrote: > Split the ioctl handler into one function per command instead of having > a all the logic sit in one giant switch statement. > > Signed-off-by: Christoph Hellwig net/ipv6/sit.c: In function ipip6_tunnel_prl_ctl: net/ipv6/sit.c:460:6:

[PATCH 5/9] sit: refactor ipip6_tunnel_ioctl

2020-05-18 Thread Christoph Hellwig
Split the ioctl handler into one function per command instead of having a all the logic sit in one giant switch statement. Signed-off-by: Christoph Hellwig --- net/ipv6/sit.c | 368 - 1 file changed, 210 insertions(+), 158 deletions(-) diff --git