Re: [PATCH 4/4] netconsole: implement extended console support

2015-05-13 Thread David Miller
From: Tejun Heo Date: Wed, 13 May 2015 11:46:20 -0400 > Hello, David. > > On Tue, May 12, 2015 at 07:23:22PM -0400, David Miller wrote: >> Second question, is there an upper bound on this header size? >> Because if there is, it seems to me that there is no reason why we >> can't just avoid the f

Re: [PATCH 4/4] netconsole: implement extended console support

2015-05-12 Thread David Miller
From: Andrew Morton Date: Tue, 12 May 2015 16:36:02 -0700 > There's no such thing as CON_EXTENDED. Not sure what this is trying to > say. Please read the patch series that, in the title posting of this series, Tejun explains this series depends upon. -- To unsubscribe from this list: send the l

Re: [PATCH 4/4] netconsole: implement extended console support

2015-05-12 Thread Andrew Morton
On Mon, 11 May 2015 12:41:34 -0400 Tejun Heo wrote: > printk logbuf keeps various metadata and optional key=value dictionary > for structured messages, both of which are stripped when messages are > handed to regular console drivers. > > It can be useful to have this metadata and dictionary avai

Re: [PATCH 4/4] netconsole: implement extended console support

2015-05-12 Thread David Miller
From: Tejun Heo Date: Mon, 11 May 2015 16:37:45 -0400 > The current code does produce the latter outcome. > > header = msg; > body = memchr(msg, ';', msg_len); > if (WARN_ON_ONCE(!body)) > return; > > header_len = body - header; > body_len = msg_len -

Re: [PATCH 4/4] netconsole: implement extended console support

2015-05-11 Thread Tejun Heo
Hello, On Mon, May 11, 2015 at 01:23:39PM -0400, David Miller wrote: > From: Tejun Heo > Date: Mon, 11 May 2015 12:41:34 -0400 > > > + /* need to insert extra header fields, detect header and body */ > > + header = msg; > > + body = memchr(msg, ';', msg_len); > > + if (WARN_ON_ONCE(!body

Re: [PATCH 4/4] netconsole: implement extended console support

2015-05-11 Thread David Miller
From: Tejun Heo Date: Mon, 11 May 2015 12:41:34 -0400 > + /* need to insert extra header fields, detect header and body */ > + header = msg; > + body = memchr(msg, ';', msg_len); > + if (WARN_ON_ONCE(!body)) > + return; > + > + header_len = body - header; > + b