Re: [PATCH 3/3] printk: implement support for extended console drivers

2015-06-29 Thread josh
On Mon, Jun 29, 2015 at 12:13:55PM -0400, Tejun Heo wrote: > On Mon, Jun 29, 2015 at 06:11:40PM +0200, Geert Uytterhoeven wrote: > > On Mon, Jun 29, 2015 at 5:49 PM, Tejun Heo wrote: > > > On Mon, Jun 29, 2015 at 05:47:49PM +0200, Geert Uytterhoeven wrote: > > >> > netconsole itself is optional &

Re: [PATCH 3/3] printk: implement support for extended console drivers

2015-06-29 Thread Tejun Heo
On Mon, Jun 29, 2015 at 06:11:40PM +0200, Geert Uytterhoeven wrote: > On Mon, Jun 29, 2015 at 5:49 PM, Tejun Heo wrote: > > On Mon, Jun 29, 2015 at 05:47:49PM +0200, Geert Uytterhoeven wrote: > >> > netconsole itself is optional & modular. I'm not sure making further > >> > splits is called for,

Re: [PATCH 3/3] printk: implement support for extended console drivers

2015-06-29 Thread josh
On Mon, Jun 29, 2015 at 11:49:14AM -0400, Tejun Heo wrote: > On Mon, Jun 29, 2015 at 05:47:49PM +0200, Geert Uytterhoeven wrote: > > > netconsole itself is optional & modular. I'm not sure making further > > > splits is called for, especially given the use cases. > > > > It could be a hidden opti

Re: [PATCH 3/3] printk: implement support for extended console drivers

2015-06-29 Thread Geert Uytterhoeven
On Mon, Jun 29, 2015 at 5:49 PM, Tejun Heo wrote: > On Mon, Jun 29, 2015 at 05:47:49PM +0200, Geert Uytterhoeven wrote: >> > netconsole itself is optional & modular. I'm not sure making further >> > splits is called for, especially given the use cases. >> >> It could be a hidden option, selected

Re: [PATCH 3/3] printk: implement support for extended console drivers

2015-06-29 Thread Tejun Heo
On Mon, Jun 29, 2015 at 05:47:49PM +0200, Geert Uytterhoeven wrote: > > netconsole itself is optional & modular. I'm not sure making further > > splits is called for, especially given the use cases. > > It could be a hidden option, selected by its users (e.g. netconsole). Hmmm... what do you mea

Re: [PATCH 3/3] printk: implement support for extended console drivers

2015-06-29 Thread Geert Uytterhoeven
Hi Tejun, On Mon, Jun 29, 2015 at 5:28 PM, Tejun Heo wrote: > On Mon, Jun 29, 2015 at 11:20:41AM +0200, Geert Uytterhoeven wrote: >> On Wed, Apr 29, 2015 at 4:45 PM, Tejun Heo wrote: >> > --- a/kernel/printk/printk.c >> > +++ b/kernel/printk/printk.c >> >> > @@ -2196,6 +2227,7 @@ out: >> > */

Re: [PATCH 3/3] printk: implement support for extended console drivers

2015-06-29 Thread Tejun Heo
Hello, On Mon, Jun 29, 2015 at 11:20:41AM +0200, Geert Uytterhoeven wrote: > On Wed, Apr 29, 2015 at 4:45 PM, Tejun Heo wrote: > > --- a/kernel/printk/printk.c > > +++ b/kernel/printk/printk.c > > > @@ -2196,6 +2227,7 @@ out: > > */ > > void console_unlock(void) > > { > > + static char

Re: [PATCH 3/3] printk: implement support for extended console drivers

2015-06-29 Thread Geert Uytterhoeven
Hi Tejun, On Wed, Apr 29, 2015 at 4:45 PM, Tejun Heo wrote: > --- a/kernel/printk/printk.c > +++ b/kernel/printk/printk.c > @@ -2196,6 +2227,7 @@ out: > */ > void console_unlock(void) > { > + static char ext_text[CONSOLE_EXT_LOG_MAX]; Can you please a) make this feature optional,