Re: [PATCH 3/3] net: macb: add missing barriers when reading buffers

2018-12-13 Thread Claudiu.Beznea
On 12.12.2018 13:27, Anssi Hannula wrote: > On 12.12.2018 12:58, claudiu.bez...@microchip.com wrote: >> >> On 11.12.2018 15:21, Anssi Hannula wrote: >>> On 10.12.2018 12:34, claudiu.bez...@microchip.com wrote: On 07.12.2018 14:00, Anssi Hannula wrote: > On 6.12.2018 16:14, claudiu.bez...

Re: [PATCH 3/3] net: macb: add missing barriers when reading buffers

2018-12-12 Thread Anssi Hannula
On 12.12.2018 12:58, claudiu.bez...@microchip.com wrote: > > On 11.12.2018 15:21, Anssi Hannula wrote: >> On 10.12.2018 12:34, claudiu.bez...@microchip.com wrote: >>> On 07.12.2018 14:00, Anssi Hannula wrote: On 6.12.2018 16:14, claudiu.bez...@microchip.com wrote: > Hi Anssi, Hi!

Re: [PATCH 3/3] net: macb: add missing barriers when reading buffers

2018-12-12 Thread Claudiu.Beznea
On 11.12.2018 15:21, Anssi Hannula wrote: > On 10.12.2018 12:34, claudiu.bez...@microchip.com wrote: >> On 07.12.2018 14:00, Anssi Hannula wrote: >>> On 6.12.2018 16:14, claudiu.bez...@microchip.com wrote: Hi Anssi, >>> Hi! >>> On 05.12.2018 16:00, Anssi Hannula wrote: > On 5.12.201

Re: [PATCH 3/3] net: macb: add missing barriers when reading buffers

2018-12-11 Thread Anssi Hannula
On 10.12.2018 12:34, claudiu.bez...@microchip.com wrote: > On 07.12.2018 14:00, Anssi Hannula wrote: >> On 6.12.2018 16:14, claudiu.bez...@microchip.com wrote: >>> Hi Anssi, >> Hi! >> >>> On 05.12.2018 16:00, Anssi Hannula wrote: On 5.12.2018 14:37, claudiu.bez...@microchip.com wrote: > On

Re: [PATCH 3/3] net: macb: add missing barriers when reading buffers

2018-12-10 Thread Claudiu.Beznea
On 07.12.2018 14:00, Anssi Hannula wrote: > On 6.12.2018 16:14, claudiu.bez...@microchip.com wrote: >> Hi Anssi, > > Hi! > >> On 05.12.2018 16:00, Anssi Hannula wrote: >>> On 5.12.2018 14:37, claudiu.bez...@microchip.com wrote: On 30.11.2018 20:21, Anssi Hannula wrote: > When reading b

Re: [PATCH 3/3] net: macb: add missing barriers when reading buffers

2018-12-07 Thread Anssi Hannula
On 6.12.2018 16:14, claudiu.bez...@microchip.com wrote: > Hi Anssi, Hi! > On 05.12.2018 16:00, Anssi Hannula wrote: >> On 5.12.2018 14:37, claudiu.bez...@microchip.com wrote: >>> On 30.11.2018 20:21, Anssi Hannula wrote: When reading buffer descriptors on RX or on TX completion, an RX_U

Re: [PATCH 3/3] net: macb: add missing barriers when reading buffers

2018-12-06 Thread Claudiu.Beznea
Hi Anssi, On 05.12.2018 16:00, Anssi Hannula wrote: > On 5.12.2018 14:37, claudiu.bez...@microchip.com wrote: >> >> On 30.11.2018 20:21, Anssi Hannula wrote: >>> When reading buffer descriptors on RX or on TX completion, an >>> RX_USED/TX_USED bit is checked first to ensure that the descriptor has

Re: [PATCH 3/3] net: macb: add missing barriers when reading buffers

2018-12-05 Thread Anssi Hannula
On 5.12.2018 14:37, claudiu.bez...@microchip.com wrote: > > On 30.11.2018 20:21, Anssi Hannula wrote: >> When reading buffer descriptors on RX or on TX completion, an >> RX_USED/TX_USED bit is checked first to ensure that the descriptor has >> been populated. However, there are no memory barriers t

Re: [PATCH 3/3] net: macb: add missing barriers when reading buffers

2018-12-05 Thread Claudiu.Beznea
On 30.11.2018 20:21, Anssi Hannula wrote: > When reading buffer descriptors on RX or on TX completion, an > RX_USED/TX_USED bit is checked first to ensure that the descriptor has > been populated. However, there are no memory barriers to ensure that the > data protected by the RX_USED/TX_USED bit

[PATCH 3/3] net: macb: add missing barriers when reading buffers

2018-11-30 Thread Anssi Hannula
When reading buffer descriptors on RX or on TX completion, an RX_USED/TX_USED bit is checked first to ensure that the descriptor has been populated. However, there are no memory barriers to ensure that the data protected by the RX_USED/TX_USED bit is up-to-date with respect to that bit. Fix that b