Re: [PATCH 3/3] forcedeth: Add support for MSI/MSIX

2006-03-18 Thread Manfred Spraul
Hi Ayaz, I know, I'm late, but: Ayaz Abdulla wrote: - disable_irq(dev->irq); + + if (!(np->msi_flags & NV_MSI_X_ENABLED) || + ((np->msi_flags & NV_MSI_X_ENABLED) && + ((np->msi_flags & NV_MSI_X_VECTORS_MASK) == 0x1))) { + disable_irq(dev->irq); + } e

Re: [PATCH 3/3] forcedeth: Add support for MSI/MSIX

2006-02-08 Thread Ayaz Abdulla
The ethernet controller is integrated into the chipset. Therefore, no mismatch between MSI/MSIX chipset support and device support should exist. Ayaz Roland Dreier wrote: Roland> Is forcedeth ever used with a discrete ethernet Roland> controller? I thought that nforce NICs are always

Re: [PATCH 3/3] forcedeth: Add support for MSI/MSIX

2006-02-06 Thread Roland Dreier
Roland> Is forcedeth ever used with a discrete ethernet Roland> controller? I thought that nforce NICs are always Roland> intergrated in the chipset, and hence the entire scope for Roland> MSI problems is within a single chip. However, I don't Roland> know if there are devices

Re: [PATCH 3/3] forcedeth: Add support for MSI/MSIX

2006-02-06 Thread Roland Dreier
Stephen> Since many motherboards and chipsets don't handle MSI Stephen> properly, it is probably better to do a test interrupt Stephen> before fully using MSI. See tg3 for an example. Is forcedeth ever used with a discrete ethernet controller? I thought that nforce NICs are always int

Re: [PATCH 3/3] forcedeth: Add support for MSI/MSIX

2006-02-06 Thread Stephen Hemminger
On Sat, 04 Feb 2006 13:13:31 -0500 Ayaz Abdulla <[EMAIL PROTECTED]> wrote: > This forcedeth patch adds support for MSI/MSIX interrupts. > > Signed-off-By: Ayaz Abdulla <[EMAIL PROTECTED]> > Since many motherboards and chipsets don't handle MSI properly, it is probably better to do a test interr

[PATCH 3/3] forcedeth: Add support for MSI/MSIX

2006-02-04 Thread Ayaz Abdulla
This forcedeth patch adds support for MSI/MSIX interrupts. Signed-off-By: Ayaz Abdulla <[EMAIL PROTECTED]> --- orig-2.6/drivers/net/forcedeth.c2006-01-21 23:50:18.0 -0500 +++ new-2.6/drivers/net/forcedeth.c 2006-01-21 23:54:37.0 -0500 @@ -104,6 +104,7 @@ * 0.49: 10