Re: [PATCH 27/32] aio: sanitize ki_list handling

2018-01-10 Thread Jeff Moyer
Christoph Hellwig writes: > Instead of handcoded non-null checks always initialize ki_list to an > empty list and use list_empty / list_empty_careful on it. Yeah, who knows why list_empty wasn't used from the beginning. In the past, tricks were played by overwriting list pointers with non-null,

[PATCH 27/32] aio: sanitize ki_list handling

2018-01-10 Thread Christoph Hellwig
Instead of handcoded non-null checks always initialize ki_list to an empty list and use list_empty / list_empty_careful on it. While we're at it also error out on a double call to kiocb_set_cancel_fn instead of ignoring it. Signed-off-by: Christoph Hellwig --- fs/aio.c | 13 ++--- 1 fil