Re: [PATCH 2.6.25] netns: struct net content re-work

2007-12-11 Thread David Miller
From: "Denis V. Lunev" <[EMAIL PROTECTED]> Date: Tue, 11 Dec 2007 10:33:45 +0300 > Eric W. Biederman wrote: > > The idea of separate structures make sense, and seems needed and useful. > > > > "Denis V. Lunev" <[EMAIL PROTECTED]> writes: > > > >> diff --git a/include/net/netns/unix.h b/include/n

Re: [PATCH 2.6.25] netns: struct net content re-work (v2)

2007-12-11 Thread David Miller
From: "Denis V. Lunev" <[EMAIL PROTECTED]> Date: Tue, 11 Dec 2007 10:45:04 +0300 > Changes from v1: > - renamed fields according to Daniel Lezcano suggestion More changes from v1: - Forgot to include net/netns/unix.h in the patch Please fix this :-) -- To unsubscribe from this list: send the lin

Re: [PATCH 2.6.25] netns: struct net content re-work (v2)

2007-12-11 Thread Daniel Lezcano
Denis V. Lunev wrote: Recently David Miller and Herbert Xu pointed out that struct net becomes overbloated and un-maintainable. There are two solutions: - provide a pointer to a network subsystem definition from struct net. This costs an additional dereferrence - place sub-system definition int

[PATCH 2.6.25] netns: struct net content re-work (v2)

2007-12-10 Thread Denis V. Lunev
Recently David Miller and Herbert Xu pointed out that struct net becomes overbloated and un-maintainable. There are two solutions: - provide a pointer to a network subsystem definition from struct net. This costs an additional dereferrence - place sub-system definition into the structure itself.

Re: [PATCH 2.6.25] netns: struct net content re-work

2007-12-10 Thread Denis V. Lunev
Eric W. Biederman wrote: > The idea of separate structures make sense, and seems needed and useful. > > "Denis V. Lunev" <[EMAIL PROTECTED]> writes: > >> diff --git a/include/net/netns/unix.h b/include/net/netns/unix.h >> new file mode 100644 >> index 000..27b4e7f >> --- /dev/null >> +++ b/in

Re: [PATCH 2.6.25] netns: struct net content re-work

2007-12-10 Thread David Miller
From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Mon, 10 Dec 2007 21:04:07 -0700 > Kirill Korotaev <[EMAIL PROTECTED]> writes: > > > Daniel Lezcano wrote: > >> Denis V. Lunev wrote: > >> Can you change this from unx to unix ? > > > > no, it won't compile. Guess why :) > > Hmm. It looks like it

Re: [PATCH 2.6.25] netns: struct net content re-work

2007-12-10 Thread Eric W. Biederman
Kirill Korotaev <[EMAIL PROTECTED]> writes: > Daniel Lezcano wrote: >> Denis V. Lunev wrote: >> >>>Recently David Miller and Herbert Xu pointed out that struct net becomes >>>overbloated and un-maintainable. There are two solutions: >>>- provide a pointer to a network subsystem definition from st

Re: [PATCH 2.6.25] netns: struct net content re-work

2007-12-10 Thread Eric W. Biederman
The idea of separate structures make sense, and seems needed and useful. "Denis V. Lunev" <[EMAIL PROTECTED]> writes: > diff --git a/include/net/netns/unix.h b/include/net/netns/unix.h > new file mode 100644 > index 000..27b4e7f > --- /dev/null > +++ b/include/net/netns/unix.h

Re: [PATCH 2.6.25] netns: struct net content re-work

2007-12-10 Thread Kirill Korotaev
Daniel Lezcano wrote: > Denis V. Lunev wrote: > >>Recently David Miller and Herbert Xu pointed out that struct net becomes >>overbloated and un-maintainable. There are two solutions: >>- provide a pointer to a network subsystem definition from struct net. >> This costs an additional dereferrence

Re: [PATCH 2.6.25] netns: struct net content re-work

2007-12-10 Thread Daniel Lezcano
Denis V. Lunev wrote: Recently David Miller and Herbert Xu pointed out that struct net becomes overbloated and un-maintainable. There are two solutions: - provide a pointer to a network subsystem definition from struct net. This costs an additional dereferrence - place sub-system definition int

[PATCH 2.6.25] netns: struct net content re-work

2007-12-10 Thread Denis V. Lunev
Recently David Miller and Herbert Xu pointed out that struct net becomes overbloated and un-maintainable. There are two solutions: - provide a pointer to a network subsystem definition from struct net. This costs an additional dereferrence - place sub-system definition into the structure itself.