Re: [PATCH 2.6.18] defxx: Big-endian hosts support

2006-11-06 Thread Jeff Garzik
Maciej W. Rozycki wrote: The PDQ DMA engine requires a different byte-swapping mode for big-endian hosts; also the MAC address which is read from a register through PIO has to be byte-swapped. These changes have been verified with DEFPA-DC (PCI) boards and a Broadcom BCM91250A (MIPS CPU based

[PATCH 2.6.18] defxx: Big-endian hosts support

2006-10-24 Thread Maciej W. Rozycki
The PDQ DMA engine requires a different byte-swapping mode for big-endian hosts; also the MAC address which is read from a register through PIO has to be byte-swapped. These changes have been verified with DEFPA-DC (PCI) boards and a Broadcom BCM91250A (MIPS CPU based) host. Signed-off-by: Macie

Re: [PATCH 2.6.18] defxx: Big-endian hosts support

2006-10-23 Thread Christoph Hellwig
On Mon, Oct 23, 2006 at 01:53:17PM +0100, Maciej W. Rozycki wrote: > + data = cpu_to_le32(data); This is rather ugly and not provable by static typechecking. Please always use spearate variables/structs for device and host endian values, and run the resulting driver through sparse to make sur

[PATCH 2.6.18] defxx: Big-endian hosts support

2006-10-23 Thread Maciej W. Rozycki
The PDQ DMA engine requires a different byte-swapping mode for big-endian hosts; also the MAC address which is read from a register through PIO has to be byte-swapped. These changes have been verified with DEFPA-DC (PCI) boards and a Broadcom BCM91250A (MIPS CPU based) host. Signed-off-by: Ma