Re: [PATCH 2/5] module: Refactor section attr into bin attribute

2020-07-08 Thread Jessica Yu
+++ Kees Cook [02/07/20 16:26 -0700]: In order to gain access to the open file's f_cred for kallsym visibility permission checks, refactor the module section attributes to use the bin_attribute instead of attribute interface. Additionally removes the redundant "name" struct member. Cc: sta...@vg

Re: [PATCH 2/5] module: Refactor section attr into bin attribute

2020-07-03 Thread Kees Cook
On Fri, Jul 03, 2020 at 08:02:07AM +0200, Greg Kroah-Hartman wrote: > On Thu, Jul 02, 2020 at 04:26:35PM -0700, Kees Cook wrote: > > + sattr->battr.size = 3 /* "0x", "\n" */ + (BITS_PER_LONG / 4); > > They get a correct "size" value now, nice! Yeah, though I do have some concerns that s

Re: [PATCH 2/5] module: Refactor section attr into bin attribute

2020-07-02 Thread Greg Kroah-Hartman
On Thu, Jul 02, 2020 at 04:26:35PM -0700, Kees Cook wrote: > In order to gain access to the open file's f_cred for kallsym visibility > permission checks, refactor the module section attributes to use the > bin_attribute instead of attribute interface. Additionally removes the > redundant "name" st

[PATCH 2/5] module: Refactor section attr into bin attribute

2020-07-02 Thread Kees Cook
In order to gain access to the open file's f_cred for kallsym visibility permission checks, refactor the module section attributes to use the bin_attribute instead of attribute interface. Additionally removes the redundant "name" struct member. Cc: sta...@vger.kernel.org Signed-off-by: Kees Cook