Re: [PATCH 2/3] bpf: Remove dead variable

2017-10-16 Thread Daniel Borkmann
On 10/16/2017 09:22 PM, Richard Weinberger wrote: [...] So, I can happily squash 2/3 into 1/3 and resent. Yeah, please just squash them. Thanks, Daniel

Re: [PATCH 2/3] bpf: Remove dead variable

2017-10-16 Thread Richard Weinberger
Am Montag, 16. Oktober 2017, 21:11:47 CEST schrieb Daniel Borkmann: > > I can squash it into 1/3, I kept it that way because > > even without 1/3 this variable is unused. > > Hmm, the helper looks like the below. In patch 1/3 you removed > the 'if (unlikely(!task))' test where the variable was us

Re: [PATCH 2/3] bpf: Remove dead variable

2017-10-16 Thread Daniel Borkmann
On 10/16/2017 08:59 PM, Richard Weinberger wrote: Am Montag, 16. Oktober 2017, 20:54:36 CEST schrieb Daniel Borkmann: On 10/16/2017 08:18 PM, Richard Weinberger wrote: task is never used in bpf_get_current_uid_gid(), kill it. Signed-off-by: Richard Weinberger --- kernel/bpf/helpers.c | 1

Re: [PATCH 2/3] bpf: Remove dead variable

2017-10-16 Thread Richard Weinberger
Am Montag, 16. Oktober 2017, 20:54:36 CEST schrieb Daniel Borkmann: > On 10/16/2017 08:18 PM, Richard Weinberger wrote: > > task is never used in bpf_get_current_uid_gid(), kill it. > > > > Signed-off-by: Richard Weinberger > > --- > > > > kernel/bpf/helpers.c | 1 - > > 1 file changed, 1 del

Re: [PATCH 2/3] bpf: Remove dead variable

2017-10-16 Thread Daniel Borkmann
On 10/16/2017 08:18 PM, Richard Weinberger wrote: task is never used in bpf_get_current_uid_gid(), kill it. Signed-off-by: Richard Weinberger --- kernel/bpf/helpers.c | 1 - 1 file changed, 1 deletion(-) diff --git a/kernel/bpf/helpers.c b/kernel/bpf/helpers.c index e8845adcd15e..511c9d522c

[PATCH 2/3] bpf: Remove dead variable

2017-10-16 Thread Richard Weinberger
task is never used in bpf_get_current_uid_gid(), kill it. Signed-off-by: Richard Weinberger --- kernel/bpf/helpers.c | 1 - 1 file changed, 1 deletion(-) diff --git a/kernel/bpf/helpers.c b/kernel/bpf/helpers.c index e8845adcd15e..511c9d522cfc 100644 --- a/kernel/bpf/helpers.c +++ b/kernel/bpf/