Re: [PATCH 2/2 net] cxgb4: ptp_clock_register() returns error pointers

2017-07-10 Thread Richard Cochran
On Mon, Jul 10, 2017 at 10:16:15AM +0300, Dan Carpenter wrote: > We're checking ptp_clock_register() for NULL but we should be checking > for error pointers. No. > diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ptp.c > b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ptp.c > index 50517cfd9671.

[PATCH 2/2 net] cxgb4: ptp_clock_register() returns error pointers

2017-07-10 Thread Dan Carpenter
We're checking ptp_clock_register() for NULL but we should be checking for error pointers. Fixes: 9c33e4208bce ("cxgb4: Add PTP Hardware Clock (PHC) support") Signed-off-by: Dan Carpenter diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ptp.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ptp.