Re: [PATCH 2/2] virtio-net: ethtool configurable RXCSUM

2020-09-29 Thread Tonghao Zhang
On Tue, Sep 29, 2020 at 3:25 PM Michael S. Tsirkin wrote: > > On Tue, Sep 29, 2020 at 03:17:50PM +0800, Tonghao Zhang wrote: > > On Tue, Sep 29, 2020 at 2:22 PM Michael S. Tsirkin wrote: > > > > > > On Tue, Sep 29, 2020 at 02:10:56PM +0800, Tonghao Zhang wrote: > > > > On Tue, Sep 29, 2020 at 1:5

Re: [PATCH 2/2] virtio-net: ethtool configurable RXCSUM

2020-09-29 Thread Michael S. Tsirkin
On Tue, Sep 29, 2020 at 03:17:50PM +0800, Tonghao Zhang wrote: > On Tue, Sep 29, 2020 at 2:22 PM Michael S. Tsirkin wrote: > > > > On Tue, Sep 29, 2020 at 02:10:56PM +0800, Tonghao Zhang wrote: > > > On Tue, Sep 29, 2020 at 1:55 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Tue, Sep 29,

Re: [PATCH 2/2] virtio-net: ethtool configurable RXCSUM

2020-09-29 Thread Tonghao Zhang
On Tue, Sep 29, 2020 at 2:22 PM Michael S. Tsirkin wrote: > > On Tue, Sep 29, 2020 at 02:10:56PM +0800, Tonghao Zhang wrote: > > On Tue, Sep 29, 2020 at 1:55 PM Michael S. Tsirkin wrote: > > > > > > On Tue, Sep 29, 2020 at 09:45:24AM +0800, Tonghao Zhang wrote: > > > > On Tue, Sep 29, 2020 at 3:2

Re: [PATCH 2/2] virtio-net: ethtool configurable RXCSUM

2020-09-28 Thread Michael S. Tsirkin
On Tue, Sep 29, 2020 at 02:10:56PM +0800, Tonghao Zhang wrote: > On Tue, Sep 29, 2020 at 1:55 PM Michael S. Tsirkin wrote: > > > > On Tue, Sep 29, 2020 at 09:45:24AM +0800, Tonghao Zhang wrote: > > > On Tue, Sep 29, 2020 at 3:25 AM Michael S. Tsirkin > > > wrote: > > > > > > > > On Mon, Sep 28,

Re: [PATCH 2/2] virtio-net: ethtool configurable RXCSUM

2020-09-28 Thread Tonghao Zhang
On Tue, Sep 29, 2020 at 1:55 PM Michael S. Tsirkin wrote: > > On Tue, Sep 29, 2020 at 09:45:24AM +0800, Tonghao Zhang wrote: > > On Tue, Sep 29, 2020 at 3:25 AM Michael S. Tsirkin wrote: > > > > > > On Mon, Sep 28, 2020 at 11:39:15AM +0800, xiangxia.m@gmail.com wrote: > > > > From: Tonghao Zh

Re: [PATCH 2/2] virtio-net: ethtool configurable RXCSUM

2020-09-28 Thread Michael S. Tsirkin
On Tue, Sep 29, 2020 at 09:45:24AM +0800, Tonghao Zhang wrote: > On Tue, Sep 29, 2020 at 3:25 AM Michael S. Tsirkin wrote: > > > > On Mon, Sep 28, 2020 at 11:39:15AM +0800, xiangxia.m@gmail.com wrote: > > > From: Tonghao Zhang > > > > > > Allow user configuring RXCSUM separately with ethtool

Re: [PATCH 2/2] virtio-net: ethtool configurable RXCSUM

2020-09-28 Thread Tonghao Zhang
On Tue, Sep 29, 2020 at 3:25 AM Michael S. Tsirkin wrote: > > On Mon, Sep 28, 2020 at 11:39:15AM +0800, xiangxia.m@gmail.com wrote: > > From: Tonghao Zhang > > > > Allow user configuring RXCSUM separately with ethtool -K, > > reusing the existing virtnet_set_guest_offloads helper > > that con

Re: [PATCH 2/2] virtio-net: ethtool configurable RXCSUM

2020-09-28 Thread Michael S. Tsirkin
On Mon, Sep 28, 2020 at 11:39:15AM +0800, xiangxia.m@gmail.com wrote: > From: Tonghao Zhang > > Allow user configuring RXCSUM separately with ethtool -K, > reusing the existing virtnet_set_guest_offloads helper > that configures RXCSUM for XDP. This is conditional on > VIRTIO_NET_F_CTRL_GUEST

Re: [PATCH 2/2] virtio-net: ethtool configurable RXCSUM

2020-09-28 Thread Tonghao Zhang
On Mon, Sep 28, 2020 at 4:39 PM Willem de Bruijn wrote: > > On Mon, Sep 28, 2020 at 5:42 AM wrote: > > > > From: Tonghao Zhang > > > > Allow user configuring RXCSUM separately with ethtool -K, > > reusing the existing virtnet_set_guest_offloads helper > > that configures RXCSUM for XDP. This is

Re: [PATCH 2/2] virtio-net: ethtool configurable RXCSUM

2020-09-28 Thread Willem de Bruijn
On Mon, Sep 28, 2020 at 5:42 AM wrote: > > From: Tonghao Zhang > > Allow user configuring RXCSUM separately with ethtool -K, > reusing the existing virtnet_set_guest_offloads helper > that configures RXCSUM for XDP. This is conditional on > VIRTIO_NET_F_CTRL_GUEST_OFFLOADS. > > Cc: Michael S. Tsi

[PATCH 2/2] virtio-net: ethtool configurable RXCSUM

2020-09-27 Thread xiangxia . m . yue
From: Tonghao Zhang Allow user configuring RXCSUM separately with ethtool -K, reusing the existing virtnet_set_guest_offloads helper that configures RXCSUM for XDP. This is conditional on VIRTIO_NET_F_CTRL_GUEST_OFFLOADS. Cc: Michael S. Tsirkin Cc: Jason Wang Signed-off-by: Tonghao Zhang ---