Re: [PATCH 2/2] net: sched: avoid duplicates in qdisc dump

2016-08-19 Thread Jiri Kosina
On Thu, 18 Aug 2016, Cong Wang wrote: > Doesn't this mean we can now just remove the ingress case from > tc_dump_qdisc() and simply iterate the whole hash table? That'd be indeed a nice cleanup, but for that we'll have to make sure that the top-level ingress entry makes it to the hashtable as w

Re: [PATCH 2/2] net: sched: avoid duplicates in qdisc dump

2016-08-18 Thread Cong Wang
On Tue, Aug 16, 2016 at 2:53 PM, Jiri Kosina wrote: > From: Jiri Kosina > > tc_dump_qdisc() performs dumping of the per-device qdiscs in two phases; > first, the "standard" dev->qdisc is being dumped. Second, if there is/are > ingress queue(s), they are being dumped as well. > > After conversion

[PATCH 2/2] net: sched: avoid duplicates in qdisc dump

2016-08-16 Thread Jiri Kosina
From: Jiri Kosina tc_dump_qdisc() performs dumping of the per-device qdiscs in two phases; first, the "standard" dev->qdisc is being dumped. Second, if there is/are ingress queue(s), they are being dumped as well. After conversion of netdevice's qdisc linked-list into hashtable, these two set