Re: [PATCH 2/2] net: phy: Don't use drv when it is NULL in phy_attached_print

2017-08-21 Thread Andrew Lunn
On Mon, Aug 21, 2017 at 09:52:35AM +0200, Romain Perier wrote: > Currently, if this logging function is used prior the phy driver is > binded to the phy device (that is usually done from .ndo_open), > 'phydev->drv' might be NULL, resulting in a kernel crash. That is > typically the case in the stmm

Re: [PATCH 2/2] net: phy: Don't use drv when it is NULL in phy_attached_print

2017-08-21 Thread Romain Perier
Hello, Le 21/08/2017 à 11:45, Sergei Shtylyov a écrit : > Hello! > > On 8/21/2017 10:52 AM, Romain Perier wrote: > >> Currently, if this logging function is used prior the phy driver is >> binded to the phy device (that is usually done from .ndo_open), > >s/binded/bound/. > >> 'phydev->drv' m

Re: [PATCH 2/2] net: phy: Don't use drv when it is NULL in phy_attached_print

2017-08-21 Thread Sergei Shtylyov
Hello! On 8/21/2017 10:52 AM, Romain Perier wrote: Currently, if this logging function is used prior the phy driver is binded to the phy device (that is usually done from .ndo_open), s/binded/bound/. 'phydev->drv' might be NULL, resulting in a kernel crash. That is typically the case in

[PATCH 2/2] net: phy: Don't use drv when it is NULL in phy_attached_print

2017-08-21 Thread Romain Perier
Currently, if this logging function is used prior the phy driver is binded to the phy device (that is usually done from .ndo_open), 'phydev->drv' might be NULL, resulting in a kernel crash. That is typically the case in the stmmac driver, info about the phy is displayed during the registration of t