Re: [PATCH 12/21] r8169: confusion between hardware and IP header alignment

2007-11-26 Thread Francois Romieu
Martin Michlmayr <[EMAIL PROTECTED]> : > * Francois Romieu <[EMAIL PROTECTED]> [2007-11-26 00:05]: > > > I'd like to backport the fix to the 2.6.18 kernel that is in our > > > stable release and have a couple of questions: > > > - Does your later patch "align the IP header when there is no DMA > >

Re: [PATCH 12/21] r8169: confusion between hardware and IP header alignment

2007-11-26 Thread Martin Michlmayr
* Francois Romieu <[EMAIL PROTECTED]> [2007-11-26 00:05]: > > I'd like to backport the fix to the 2.6.18 kernel that is in our > > stable release and have a couple of questions: > > - Does your later patch "align the IP header when there is no DMA > >constraint" fix any bugs or is it merely an

Re: [PATCH 12/21] r8169: confusion between hardware and IP header alignment

2007-11-25 Thread Francois Romieu
Martin Michlmayr <[EMAIL PROTECTED]> : [...] > I'd like to backport the fix to the 2.6.18 kernel that is in our > stable release and have a couple of questions: > - Does your later patch "align the IP header when there is no DMA >constraint" fix any bugs or is it merely an improvement? It fix

Re: [PATCH 12/21] r8169: confusion between hardware and IP header alignment

2007-11-22 Thread Martin Michlmayr
Hi Francois, A Debian user reported that NFS transfers are not working correctly on a Thecus N2100 (which has two 8169 ports). I confirmed this bug with 2.6.18 and 2.6.22 but couldn't reproduce it with 2.6.23. A git bisect has revealed that your patch "confusion between hardware and IP header al

[PATCH 12/21] r8169: confusion between hardware and IP header alignment

2007-06-29 Thread Francois Romieu
The rx copybreak part is straightforward. The align field in struct rtl_cfg_info is related to the alignment requirements of the DMA operation. Its value is set at 2 to limit the scale of possible regression but my old v1.21 8169 datasheet claims a 8 bytes requirements (which never appeared in the