Re: [PATCH 12/15] ptp: use permission-specific DEVICE_ATTR variants

2016-10-31 Thread David Miller
From: Julia Lawall Date: Sat, 29 Oct 2016 21:37:06 +0200 > Use DEVICE_ATTR_RO for read only attributes. This simplifies the > source code, improves readbility, and reduces the chance of > inconsistencies. > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/

Re: [PATCH 12/15] ptp: use permission-specific DEVICE_ATTR variants

2016-10-31 Thread Richard Cochran
On Sat, Oct 29, 2016 at 09:37:06PM +0200, Julia Lawall wrote: > Use DEVICE_ATTR_RO for read only attributes. This simplifies the > source code, improves readbility, and reduces the chance of > inconsistencies. Acked-by: Richard Cochran

[PATCH 12/15] ptp: use permission-specific DEVICE_ATTR variants

2016-10-29 Thread Julia Lawall
Use DEVICE_ATTR_RO for read only attributes. This simplifies the source code, improves readbility, and reduces the chance of inconsistencies. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @ro@ declarer name DEVICE_ATTR; identifier x,x_show; @@ DEVICE_