Re: [PATCH 12/15] maccess: always use strict semantics for probe_kernel_read

2020-05-10 Thread Masami Hiramatsu
On Mon, 11 May 2020 14:05:36 +0900 Masami Hiramatsu wrote: > Hi Christoph, > > At first, thank you for your work on cleaning up these functions! > > On Wed, 6 May 2020 08:22:20 +0200 > Christoph Hellwig wrote: > > > Except for historical confusion in the kprobes/uprobes and bpf tracers > > t

Re: [PATCH 12/15] maccess: always use strict semantics for probe_kernel_read

2020-05-10 Thread Masami Hiramatsu
Hi Christoph, At first, thank you for your work on cleaning up these functions! On Wed, 6 May 2020 08:22:20 +0200 Christoph Hellwig wrote: > Except for historical confusion in the kprobes/uprobes and bpf tracers > there is no good reason to ever allow user memory accesses from > probe_kernel_r

[PATCH 12/15] maccess: always use strict semantics for probe_kernel_read

2020-05-05 Thread Christoph Hellwig
Except for historical confusion in the kprobes/uprobes and bpf tracers there is no good reason to ever allow user memory accesses from probe_kernel_read. Make the tracers fall back to a probe_user_read if the probe_kernel_read falls to keep the core API clean. Signed-off-by: Christoph Hellwig --