Re: [PATCH 12/14] net: sched: retry action check-insert on concurrent modification

2018-05-19 Thread Marcelo Ricardo Leitner
On Wed, May 16, 2018 at 03:21:35PM +0200, Jiri Pirko wrote: ... > int tcf_idr_check_alloc(struct tc_action_net *tn, u32 *index, > struct tc_action **a, int bind) Considering we don't have any other variant of it, maybe just "tcf_idr_alloc()" instead?

Re: [PATCH 12/14] net: sched: retry action check-insert on concurrent modification

2018-05-16 Thread Jiri Pirko
Wed, May 16, 2018 at 04:26:40PM CEST, vla...@mellanox.com wrote: > >On Wed 16 May 2018 at 14:13, Jiri Pirko wrote: >> Wed, May 16, 2018 at 03:52:20PM CEST, vla...@mellanox.com wrote: >>> >>>On Wed 16 May 2018 at 13:21, Jiri Pirko wrote: Wed, May 16, 2018 at 02:43:58PM CEST, vla...@mellanox.c

Re: [PATCH 12/14] net: sched: retry action check-insert on concurrent modification

2018-05-16 Thread Vlad Buslov
On Wed 16 May 2018 at 14:13, Jiri Pirko wrote: > Wed, May 16, 2018 at 03:52:20PM CEST, vla...@mellanox.com wrote: >> >>On Wed 16 May 2018 at 13:21, Jiri Pirko wrote: >>> Wed, May 16, 2018 at 02:43:58PM CEST, vla...@mellanox.com wrote: On Wed 16 May 2018 at 12:26, Jiri Pirko wrote:

Re: [PATCH 12/14] net: sched: retry action check-insert on concurrent modification

2018-05-16 Thread Jiri Pirko
Wed, May 16, 2018 at 03:52:20PM CEST, vla...@mellanox.com wrote: > >On Wed 16 May 2018 at 13:21, Jiri Pirko wrote: >> Wed, May 16, 2018 at 02:43:58PM CEST, vla...@mellanox.com wrote: >>> >>>On Wed 16 May 2018 at 12:26, Jiri Pirko wrote: Wed, May 16, 2018 at 01:55:06PM CEST, vla...@mellanox.c

Re: [PATCH 12/14] net: sched: retry action check-insert on concurrent modification

2018-05-16 Thread Vlad Buslov
On Wed 16 May 2018 at 13:21, Jiri Pirko wrote: > Wed, May 16, 2018 at 02:43:58PM CEST, vla...@mellanox.com wrote: >> >>On Wed 16 May 2018 at 12:26, Jiri Pirko wrote: >>> Wed, May 16, 2018 at 01:55:06PM CEST, vla...@mellanox.com wrote: On Wed 16 May 2018 at 09:59, Jiri Pirko wrote:

Re: [PATCH 12/14] net: sched: retry action check-insert on concurrent modification

2018-05-16 Thread Jiri Pirko
Wed, May 16, 2018 at 02:43:58PM CEST, vla...@mellanox.com wrote: > >On Wed 16 May 2018 at 12:26, Jiri Pirko wrote: >> Wed, May 16, 2018 at 01:55:06PM CEST, vla...@mellanox.com wrote: >>> >>>On Wed 16 May 2018 at 09:59, Jiri Pirko wrote: Mon, May 14, 2018 at 04:27:13PM CEST, vla...@mellanox.c

Re: [PATCH 12/14] net: sched: retry action check-insert on concurrent modification

2018-05-16 Thread Vlad Buslov
On Wed 16 May 2018 at 12:26, Jiri Pirko wrote: > Wed, May 16, 2018 at 01:55:06PM CEST, vla...@mellanox.com wrote: >> >>On Wed 16 May 2018 at 09:59, Jiri Pirko wrote: >>> Mon, May 14, 2018 at 04:27:13PM CEST, vla...@mellanox.com wrote: Retry check-insert sequence in action init functions if a

Re: [PATCH 12/14] net: sched: retry action check-insert on concurrent modification

2018-05-16 Thread Jiri Pirko
Wed, May 16, 2018 at 01:55:06PM CEST, vla...@mellanox.com wrote: > >On Wed 16 May 2018 at 09:59, Jiri Pirko wrote: >> Mon, May 14, 2018 at 04:27:13PM CEST, vla...@mellanox.com wrote: >>>Retry check-insert sequence in action init functions if action with same >>>index was inserted concurrently. >>>

Re: [PATCH 12/14] net: sched: retry action check-insert on concurrent modification

2018-05-16 Thread Vlad Buslov
On Wed 16 May 2018 at 09:59, Jiri Pirko wrote: > Mon, May 14, 2018 at 04:27:13PM CEST, vla...@mellanox.com wrote: >>Retry check-insert sequence in action init functions if action with same >>index was inserted concurrently. >> >>Signed-off-by: Vlad Buslov >>--- >> net/sched/act_bpf.c| 8

Re: [PATCH 12/14] net: sched: retry action check-insert on concurrent modification

2018-05-16 Thread Jiri Pirko
Mon, May 14, 2018 at 04:27:13PM CEST, vla...@mellanox.com wrote: >Retry check-insert sequence in action init functions if action with same >index was inserted concurrently. > >Signed-off-by: Vlad Buslov >--- > net/sched/act_bpf.c| 8 +++- > net/sched/act_connmark.c | 8 +++- > net/

[PATCH 12/14] net: sched: retry action check-insert on concurrent modification

2018-05-14 Thread Vlad Buslov
Retry check-insert sequence in action init functions if action with same index was inserted concurrently. Signed-off-by: Vlad Buslov --- net/sched/act_bpf.c| 8 +++- net/sched/act_connmark.c | 8 +++- net/sched/act_csum.c | 8 +++- net/sched/act_gact.c | 8 +