Re: [PATCH 11/21] nbd: limit blk_queue

2006-09-06 Thread Jens Axboe
On Wed, Sep 06 2006, Erik Mouw wrote: > On Wed, Sep 06, 2006 at 03:16:41PM +0200, Peter Zijlstra wrote: > > - disk->queue = blk_init_queue(do_nbd_request, &nbd_lock); > > + disk->queue = blk_init_queue_node_elv(do_nbd_request, > > + &nbd_lock, -1, "noop

Re: [PATCH 11/21] nbd: limit blk_queue

2006-09-06 Thread Erik Mouw
On Wed, Sep 06, 2006 at 03:16:41PM +0200, Peter Zijlstra wrote: > - disk->queue = blk_init_queue(do_nbd_request, &nbd_lock); > + disk->queue = blk_init_queue_node_elv(do_nbd_request, > + &nbd_lock, -1, "noop"); So what happens if the noop schedul

[PATCH 11/21] nbd: limit blk_queue

2006-09-06 Thread Peter Zijlstra
Limit each request to 1 page, so that the request throttling also limits the number of in-flight pages and force the IO scheduler to NOOP as anything else doesn't make sense anyway. (Pavel, I will analyse those !NOOP deadlocks I got, I'm just re-posting so people can comment on the rest) Signed-