Re: [PATCH 10/11] ah6: fix error return code

2015-08-25 Thread David Miller
From: Julia Lawall Date: Sun, 23 Aug 2015 02:11:21 +0200 > Return a negative error code on failure. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/) ... > Signed-off-by: Julia Lawall Applied and as noticed by Herbert Xu I fix

Re: [PATCH 10/11] ah6: fix error return code

2015-08-24 Thread Herbert Xu
On Sun, Aug 23, 2015 at 02:11:21AM +0200, Julia Lawall wrote: > Return a negative error code on failure. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/) > > // > @@ > identifier ret; expression e1,e2; > @@ > ( > if (\(ret < 0\|

[PATCH 10/11] ah6: fix error return code

2015-08-22 Thread Julia Lawall
Return a negative error code on failure. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier ret; expression e1,e2; @@ ( if (\(ret < 0\|ret != 0\)) { ... return ret; } | ret = 0 ) ... when != ret = e1 when != &ret *