Re: [PATCH 1/9] l2tp: don't log data frames

2020-08-21 Thread Tom Parkin
On Fri, Aug 21, 2020 at 20:28:59 +0800, kernel test robot wrote: > Hi Tom, > > Thank you for the patch! Perhaps something to improve: > [snip] > >net/l2tp/l2tp_core.c: In function 'l2tp_recv_common': > >> net/l2tp/l2tp_core.c:663:14: warning: variable 'nr' set but not used > >> [-Wunused-b

Re: [PATCH 1/9] l2tp: don't log data frames

2020-08-21 Thread kernel test robot
Hi Tom, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Tom-Parkin/l2tp-replace-custom-logging-code-with-tracepoints/20200821-184919 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem

[PATCH 1/9] l2tp: don't log data frames

2020-08-21 Thread Tom Parkin
l2tp had logging to trace data frame receipt and transmission, including code to dump packet contents. This was originally intended to aid debugging of core l2tp packet handling, but is of limited use now that code is stable. Signed-off-by: Tom Parkin --- net/l2tp/l2tp_core.c | 44 +