Re: [PATCH 1/7] devlink: Add permanent config parameter get/set operations

2017-10-18 Thread Steve Lin
On Wed, Oct 18, 2017 at 11:22 AM, Or Gerlitz wrote: > On Tue, Oct 17, 2017 at 11:44 PM, Steve Lin > wrote: >> >> Add support for permanent config parameter get/set commands. Used >> for parameters held in NVRAM, persistent device configuration. >> The config_get() and config_set() operations oper

Re: [PATCH 1/7] devlink: Add permanent config parameter get/set operations

2017-10-18 Thread Jiri Pirko
Wed, Oct 18, 2017 at 03:14:35PM CEST, steven.l...@broadcom.com wrote: >On Wed, Oct 18, 2017 at 8:58 AM, Jiri Pirko wrote: >> Wed, Oct 18, 2017 at 02:39:09PM CEST, steven.l...@broadcom.com wrote: >>>On Wed, Oct 18, 2017 at 3:11 AM, Jiri Pirko wrote: Tue, Oct 17, 2017 at 10:44:23PM CEST, steve

Re: [PATCH 1/7] devlink: Add permanent config parameter get/set operations

2017-10-18 Thread Steve Lin
On Wed, Oct 18, 2017 at 8:58 AM, Jiri Pirko wrote: > Wed, Oct 18, 2017 at 02:39:09PM CEST, steven.l...@broadcom.com wrote: >>On Wed, Oct 18, 2017 at 3:11 AM, Jiri Pirko wrote: >>> Tue, Oct 17, 2017 at 10:44:23PM CEST, steven.l...@broadcom.com wrote: >>> Steve. As I originally requested, could you

Re: [PATCH 1/7] devlink: Add permanent config parameter get/set operations

2017-10-18 Thread Jiri Pirko
Wed, Oct 18, 2017 at 02:39:09PM CEST, steven.l...@broadcom.com wrote: >On Wed, Oct 18, 2017 at 3:11 AM, Jiri Pirko wrote: >> Tue, Oct 17, 2017 at 10:44:23PM CEST, steven.l...@broadcom.com wrote: >> Steve. As I originally requested, could you please split this to: >> 1) single patch adding config g

Re: [PATCH 1/7] devlink: Add permanent config parameter get/set operations

2017-10-18 Thread Steve Lin
On Wed, Oct 18, 2017 at 3:11 AM, Jiri Pirko wrote: > Tue, Oct 17, 2017 at 10:44:23PM CEST, steven.l...@broadcom.com wrote: > Steve. As I originally requested, could you please split this to: > 1) single patch adding config get/set commands, without any config attributes > 2) single patch per confi

Re: [PATCH 1/7] devlink: Add permanent config parameter get/set operations

2017-10-18 Thread Jiri Pirko
Tue, Oct 17, 2017 at 10:44:23PM CEST, steven.l...@broadcom.com wrote: >Add support for permanent config parameter get/set commands. Used >for parameters held in NVRAM, persistent device configuration. >The config_get() and config_set() operations operate as expected, but >note that the driver imple

[PATCH 1/7] devlink: Add permanent config parameter get/set operations

2017-10-17 Thread Steve Lin
Add support for permanent config parameter get/set commands. Used for parameters held in NVRAM, persistent device configuration. The config_get() and config_set() operations operate as expected, but note that the driver implementation of the config_set() operation can indicate whether a restart is