Re: [PATCH 1/7] Preparatory refactoring part 1.

2007-07-31 Thread Patrick McHardy
Corey Hickey wrote: > Patrick McHardy wrote: > >>> -static int >>> -sfq_enqueue(struct sk_buff *skb, struct Qdisc* sch) >>> +static void sfq_q_enqueue(struct sk_buff *skb, struct sfq_sched_data >>> *q, unsigned int end) >> >> >> >> Please make sure to break at 80 chars and to keep the style >> in

Re: [PATCH 1/7] Preparatory refactoring part 1.

2007-07-30 Thread Corey Hickey
Patrick McHardy wrote: -static int -sfq_enqueue(struct sk_buff *skb, struct Qdisc* sch) +static void sfq_q_enqueue(struct sk_buff *skb, struct sfq_sched_data *q, unsigned int end) Please make sure to break at 80 chars and to keep the style in this file consistent (newline before function name

Re: [PATCH 1/7] Preparatory refactoring part 1.

2007-07-30 Thread Patrick McHardy
Corey Hickey wrote: > diff --git a/net/sched/sch_sfq.c b/net/sched/sch_sfq.c > index 9579573..8ae077f 100644 > --- a/net/sched/sch_sfq.c > +++ b/net/sched/sch_sfq.c > @@ -77,6 +77,9 @@ > #define SFQ_DEPTH128 > #define SFQ_HASH_DIVISOR 1024 > > +#define SFQ_HEAD 0 > +#define SFQ_

[PATCH 1/7] Preparatory refactoring part 1.

2007-07-29 Thread Corey Hickey
Make a new function sfq_q_enqueue() that operates directly on the queue data. This will be useful for implementing sfq_change() in a later patch. A pleasant side-effect is reducing most of the duplicate code in sfq_enqueue() and sfq_requeue(). Similarly, make a new function sfq_q_dequeue(). Signe

[PATCH 1/7] Preparatory refactoring part 1.

2007-07-29 Thread Corey Hickey
Make a new function sfq_q_enqueue() that operates directly on the queue data. This will be useful for implementing sfq_change() in a later patch. A pleasant side-effect is reducing most of the duplicate code in sfq_enqueue() and sfq_requeue(). Similarly, make a new function sfq_q_dequeue(). Signe