Re: [PATCH 1/6] Convert bonding timers to workqueues

2007-10-23 Thread Jeff Garzik
Andy Gospodarek wrote: On Tue, Oct 23, 2007 at 06:00:01PM -0700, Jay Vosburgh wrote: Jeff Garzik <[EMAIL PROTECTED]> wrote: applied patches 1-6 Thanks. However, two issues: 1) Credit. Did Andy write these, as the Signed-off-by lines indicate? Andy did some of it and I di

Re: [PATCH 1/6] Convert bonding timers to workqueues

2007-10-23 Thread Andy Gospodarek
On Tue, Oct 23, 2007 at 06:00:01PM -0700, Jay Vosburgh wrote: > Jeff Garzik <[EMAIL PROTECTED]> wrote: > > >applied patches 1-6 > > Thanks. > > >However, two issues: > > > >1) Credit. Did Andy write these, as the Signed-off-by lines indicate? > > Andy did some of it and I did some

Re: [PATCH 1/6] Convert bonding timers to workqueues

2007-10-23 Thread Jay Vosburgh
Jeff Garzik <[EMAIL PROTECTED]> wrote: >applied patches 1-6 Thanks. >However, two issues: > >1) Credit. Did Andy write these, as the Signed-off-by lines indicate? Andy did some of it and I did some of it, so I presume that dual Signed-off-by is correct (vs. one Signed-off and

Re: [PATCH 1/6] Convert bonding timers to workqueues

2007-10-23 Thread Jeff Garzik
Jay Vosburgh wrote: Convert bonding timers to workqueues. This converts the various monitor functions to run in periodic work queues instead of timers. This patch introduces the framework and convers the calls, but does not resolve various locking issues, and does not stand alone. Sign

Re: [PATCH 1/6] Convert bonding timers to workqueues

2007-10-22 Thread Jay Vosburgh
Jeff Garzik <[EMAIL PROTECTED]> wrote: [...] >I wasn't aware this brand-new code is a bug fix? > >Normally brand new code needs to be posted and reviewed and committed to a >tree -before- the merge window opens. I had thought this was going in ok, as you'd attempted to apply it after the I

Re: [PATCH 1/6] Convert bonding timers to workqueues

2007-10-22 Thread Jeff Garzik
Mike Snitzer wrote: Given that Jay rebased and posted updated bonding locking patches on Oct 17 will you be pushing them for inclusion in 2.6.24-rc1? or 2.6.24-rcX? I don't see them queued in your netdev-2.6 tree. These bonding locking issues have been a problem for some time and it would be v

Re: [PATCH 1/6] Convert bonding timers to workqueues

2007-10-22 Thread Mike Snitzer
On 10/15/07, Jay Vosburgh <[EMAIL PROTECTED]> wrote: > Jeff Garzik <[EMAIL PROTECTED]> wrote: > > >Jay Vosburgh wrote: > >> Convert bonding timers to workqueues. This converts the various > >> monitor functions to run in periodic work queues instead of timers. This > >> patch introduces the

[PATCH 1/6] Convert bonding timers to workqueues

2007-10-17 Thread Jay Vosburgh
Convert bonding timers to workqueues. This converts the various monitor functions to run in periodic work queues instead of timers. This patch introduces the framework and convers the calls, but does not resolve various locking issues, and does not stand alone. Signed-off-by: Andy Gospod

Re: [PATCH 1/6] Convert bonding timers to workqueues

2007-10-15 Thread Jay Vosburgh
Jeff Garzik <[EMAIL PROTECTED]> wrote: >Jay Vosburgh wrote: >> Convert bonding timers to workqueues. This converts the various >> monitor functions to run in periodic work queues instead of timers. This >> patch introduces the framework and convers the calls, but does not resolve >> various

Re: [PATCH 1/6] Convert bonding timers to workqueues

2007-10-15 Thread Jeff Garzik
Jay Vosburgh wrote: Convert bonding timers to workqueues. This converts the various monitor functions to run in periodic work queues instead of timers. This patch introduces the framework and convers the calls, but does not resolve various locking issues, and does not stand alone. Sign

[PATCH 1/6] Convert bonding timers to workqueues

2007-10-10 Thread Jay Vosburgh
Convert bonding timers to workqueues. This converts the various monitor functions to run in periodic work queues instead of timers. This patch introduces the framework and convers the calls, but does not resolve various locking issues, and does not stand alone. Signed-off-by: Andy Gospod