Re: [PATCH 1/4] net: make dev_kfree_skb_irq not inline

2006-12-14 Thread David Miller
From: Christoph Hellwig <[EMAIL PROTECTED]> Date: Thu, 14 Dec 2006 22:30:09 + > Maybe you should only move the slowpath out of line ala: > > static inline void dev_kfree_skb_irq(struct sk_buff *skb) > { > if (atomic_dec_and_test(&skb->users)) > __dev_kfree_skb_irq(skb); >

Re: [PATCH 1/4] net: make dev_kfree_skb_irq not inline

2006-12-14 Thread Stephen Hemminger
On Thu, 14 Dec 2006 22:30:09 + Christoph Hellwig <[EMAIL PROTECTED]> wrote: > On Thu, Dec 14, 2006 at 12:48:15PM -0800, Stephen Hemminger wrote: > > Move the dev_kfree_skb_irq function from netdevice.h to dev.c > > for a couple of reasons. Primarily, I want to make softnet_data > > local to de

Re: [PATCH 1/4] net: make dev_kfree_skb_irq not inline

2006-12-14 Thread Christoph Hellwig
On Thu, Dec 14, 2006 at 12:48:15PM -0800, Stephen Hemminger wrote: > Move the dev_kfree_skb_irq function from netdevice.h to dev.c > for a couple of reasons. Primarily, I want to make softnet_data > local to dev.c; also this function is called 300+ places already. > > Signed-off-by: Stephen Hemmin

[PATCH 1/4] net: make dev_kfree_skb_irq not inline

2006-12-14 Thread Stephen Hemminger
Move the dev_kfree_skb_irq function from netdevice.h to dev.c for a couple of reasons. Primarily, I want to make softnet_data local to dev.c; also this function is called 300+ places already. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- linux-2.6.20-rc1.orig/include/linux/netdevice.h