Re: [PATCH 1/3 v2][NET] gen_estimator: faster gen_kill_estimator

2008-01-22 Thread Jarek Poplawski
On Tue, Jan 22, 2008 at 08:54:28AM -0500, jamal wrote: > On Tue, 2008-22-01 at 13:29 +0100, Jarek Poplawski wrote: > > On Tue, Jan 22, 2008 at 06:42:07AM -0500, jamal wrote: > > ... > > > Jarek, > > > > > > That looks different from the suggestion from Dave. > > > > Hmm..., I'm not sure you mean

Re: [PATCH 1/3 v2][NET] gen_estimator: faster gen_kill_estimator

2008-01-22 Thread jamal
On Tue, 2008-22-01 at 13:29 +0100, Jarek Poplawski wrote: > On Tue, Jan 22, 2008 at 06:42:07AM -0500, jamal wrote: > ... > > Jarek, > > > > That looks different from the suggestion from Dave. > > Hmm..., I'm not sure you mean my or your suggestion here, but you > are right anyway... Your idea to

Re: [PATCH 1/3 v2][NET] gen_estimator: faster gen_kill_estimator

2008-01-22 Thread Jarek Poplawski
On Tue, Jan 22, 2008 at 06:42:07AM -0500, jamal wrote: ... > Jarek, > > That looks different from the suggestion from Dave. Hmm..., I'm not sure you mean my or your suggestion here, but you are right anyway... > May i throw in another bone? Theoretically i can see why it would be a > really bad

Re: [PATCH 1/3 v2][NET] gen_estimator: faster gen_kill_estimator

2008-01-22 Thread jamal
On Tue, 2008-22-01 at 08:21 +0100, Jarek Poplawski wrote: > On 22-01-2008 01:29, David Miller wrote: > ... > > Fix this right, make a structure like: > > > > struct kernel_gnet_stats_rate_est { > > struct gnet_stats_rate_est est; > > void*gen_estimator; > >

Re: [PATCH 1/3 v2][NET] gen_estimator: faster gen_kill_estimator

2008-01-21 Thread Jarek Poplawski
On Tue, Jan 22, 2008 at 08:21:52AM +0100, Jarek Poplawski wrote: ... Part 2 of mini RFC: HTB changes to use new, faster gen_estimator functions._ This is done against 2.6.24-rc8-mm1. Thanks, Jarek P. --- diff -Nurp 2.6.24-rc8-mm1-/net/sched/sch_htb.c 2.6.24-rc8-mm1+/net/sched/sch_htb.c ---

Re: [PATCH 1/3 v2][NET] gen_estimator: faster gen_kill_estimator

2008-01-21 Thread Jarek Poplawski
On 22-01-2008 01:29, David Miller wrote: ... > Fix this right, make a structure like: > > struct kernel_gnet_stats_rate_est { > struct gnet_stats_rate_est est; > void*gen_estimator; > } > > And update all the code as needed. Thanks! I'll try this...

Re: [PATCH 1/3 v2][NET] gen_estimator: faster gen_kill_estimator

2008-01-21 Thread David Miller
From: Jarek Poplawski <[EMAIL PROTECTED]> Date: Mon, 21 Jan 2008 23:31:37 +0100 > > So, let's try something easy first: #ifdef __KERNEL__. (I know there > are many esthetes around, but since this subject looks quite dirty...) You can't do this, the attribute is copied to the user netlink SKB usi

Re: [PATCH 1/3 v2][NET] gen_estimator: faster gen_kill_estimator

2008-01-21 Thread Jarek Poplawski
On Mon, Jan 21, 2008 at 11:31:37PM +0100, Jarek Poplawski wrote: > > So, let's try something easy first: #ifdef __KERNEL__. (I know there ... SORRY!!! Of course this is still wrong, I withdraw this patch. Jarek P. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body o

[PATCH 1/3 v2][NET] gen_estimator: faster gen_kill_estimator

2008-01-21 Thread Jarek Poplawski
So, let's try something easy first: #ifdef __KERNEL__. (I know there are many esthetes around, but since this subject looks quite dirty...) Alternatively we could change an api, and as a matter of fact there was such a try some time ago, but is it really worth of such a mess? Regards, Jarek P. -